diff mbox series

pci: fix missing off_t define on FreeBSD

Message ID 20200316163705.5675-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Headers
Series pci: fix missing off_t define on FreeBSD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation fail apply issues

Commit Message

Bruce Richardson March 16, 2020, 4:37 p.m. UTC 
  When removing the extra headers from rte_pci.h stdlib should have been
removed instead of stdio, since off_t is missing for BSD builds when just
including stdlib.h

Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_pci/rte_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon March 17, 2020, 9:24 a.m. UTC | #1 
16/03/2020 17:37, Bruce Richardson:
> When removing the extra headers from rte_pci.h stdlib should have been
> removed instead of stdio, since off_t is missing for BSD builds when just
> including stdlib.h
> 
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Sorry, I missed the failure seen in the community lab:
	http://mails.dpdk.org/archives/test-report/2020-March/120862.html
Note: we should always wait for tests to be run.
Thank you for the quick fix.

Applied, thanks
diff mbox series

Patch

diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h
index c591af010..4087771c1 100644
--- a/lib/librte_pci/rte_pci.h
+++ b/lib/librte_pci/rte_pci.h
@@ -16,7 +16,7 @@ 
 extern "C" {
 #endif
 
-#include <stdlib.h>
+#include <stdio.h>
 #include <limits.h>
 #include <sys/queue.h>
 #include <inttypes.h>