diff mbox series

ci: fix telemetry dependency in Travis

Message ID 1585917949-13468-1-git-send-email-juraj.linkes@pantheon.tech (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series ci: fix telemetry dependency in Travis |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS

Commit Message

Juraj Linkeš April 3, 2020, 12:45 p.m. UTC 
  From: "juraj.linkes" <juraj.linkes@pantheon.tech>

libjansson4 is not enough to build telemetry. Replace it with
libjansson-dev.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole April 3, 2020, 2:41 p.m. UTC | #1 
juraj.linkes@pantheon.tech writes:

> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

I see that earlier builds would print:

  =================
  Content Skipped
  =================

  libs:
	telemetry:	missing dependency "jansson"


But with this patch, I see that telemetry is included in the built libs.

Thanks for the catch.

Acked-by: Aaron Conole <aconole@redhat.com>
Ruifeng Wang April 3, 2020, 3:08 p.m. UTC | #2 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> juraj.linkes@pantheon.tech
> Sent: Friday, April 3, 2020 8:46 PM
> To: aconole@redhat.com; maicolgabriel@hotmail.com
> Cc: dev@dpdk.org; juraj.linkes <juraj.linkes@pantheon.tech>
> Subject: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
> 
> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
> 
> libjansson4 is not enough to build telemetry. Replace it with libjansson-dev.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fd4f79cfc..2d2292ff6 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,7 +15,7 @@ addons:
>      update: true
>      packages: &required_packages
>        - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-
> build]
> -      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev,
> libjansson4]
> +      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev,
> + libfdt-dev, libjansson-dev]
> 
>  _aarch64_packages: &aarch64_packages
>    - *required_packages
> --
> 2.11.0

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
diff mbox series

Patch

diff --git a/.travis.yml b/.travis.yml
index fd4f79cfc..2d2292ff6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,7 +15,7 @@  addons:
     update: true
     packages: &required_packages
       - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]
-      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4]
+      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]
 
 _aarch64_packages: &aarch64_packages
   - *required_packages