diff mbox series

fix memif does not free resources

Message ID 20200404101557.27567-2-podovinnikov@protei.ru (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series fix memif does not free resources |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

podovinnikov April 4, 2020, 10:15 a.m. UTC 
  Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
---
 drivers/net/memif/rte_eth_memif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Hemminger April 4, 2020, 9:48 p.m. UTC | #1 
On Sat,  4 Apr 2020 13:15:57 +0300
Vadim Podovinnikov <podovinnikov@protei.ru> wrote:

> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
> ---
>  drivers/net/memif/rte_eth_memif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
> index 81d71c53a..653ffa9b8 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
>  	}
>  
>  
> -	eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
> +	eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>  
>  	rte_eth_dev_probing_finish(eth_dev);
>  

This looks like a bug fix, please add.

Fixes: c41a04958b09 ("net/memif: support multi-process")
Cc: jgrajcia@cisco.com
Ferruh Yigit April 7, 2020, 10:14 a.m. UTC | #2 
On 4/4/2020 10:48 PM, Stephen Hemminger wrote:
> On Sat,  4 Apr 2020 13:15:57 +0300
> Vadim Podovinnikov <podovinnikov@protei.ru> wrote:
> 
>> Signed-off-by: Vadim Podovinnikov <podovinnikov@protei.ru>
>> ---
>>  drivers/net/memif/rte_eth_memif.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
>> index 81d71c53a..653ffa9b8 100644
>> --- a/drivers/net/memif/rte_eth_memif.c
>> +++ b/drivers/net/memif/rte_eth_memif.c
>> @@ -1510,7 +1510,7 @@ memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
>>  	}
>>  
>>  
>> -	eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
>> +	eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
>>  
>>  	rte_eth_dev_probing_finish(eth_dev);
>>  
> 
> This looks like a bug fix, please add.
> 
> Fixes: c41a04958b09 ("net/memif: support multi-process")
> Cc: jgrajcia@cisco.com
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 81d71c53a..653ffa9b8 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -1510,7 +1510,7 @@  memif_create(struct rte_vdev_device *vdev, enum memif_role_t role,
 	}
 
 
-	eth_dev->data->dev_flags &= RTE_ETH_DEV_CLOSE_REMOVE;
+	eth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;
 
 	rte_eth_dev_probing_finish(eth_dev);