[v5] crypto/aesni_mb: support DOCSIS AES-256

Message ID 1586941457-28531-1-git-send-email-mairtin.oloingsigh@intel.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series [v5] crypto/aesni_mb: support DOCSIS AES-256 |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Mairtin o Loingsigh April 15, 2020, 9:04 a.m. UTC
  This patch adds support for DOCSIS AES-256 when using AESNI-MB

Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
---
v2: Added IPSec MB version check
v3: Added doc update
v4: Added missing patch
v5: Dropping test vector due to refactoring
---
 doc/guides/rel_notes/release_20_05.rst         | 5 +++++
 drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
 2 files changed, 11 insertions(+)
  

Comments

De Lara Guarch, Pablo April 15, 2020, 11:07 a.m. UTC | #1
Hi Mairtin,

> -----Original Message-----
> From: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Sent: Wednesday, April 15, 2020 10:04 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Subject: [PATCH v5] crypto/aesni_mb: support DOCSIS AES-256
> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> Acked-by: Pablo de Lara <Pablo.de.lara.guarch@intel.com>
> ---
> v2: Added IPSec MB version check
> v3: Added doc update
> v4: Added missing patch
> v5: Dropping test vector due to refactoring
> ---
>  doc/guides/rel_notes/release_20_05.rst         | 5 +++++
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 6 ++++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 6b1a7c58c..72d2f6c27 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -81,6 +81,11 @@ New Features
>    by making use of the event device capabilities. The event mode currently
> supports
>    only inline IPsec protocol offload.
> 
> +* **Updated the AESNI MB PMD.**
> +
> +  Updated the AESNI PMD with additional DOCSIS algorithm
> +
> +  * Added support for AES-256 DOCSIS
> 
>  Removed Items
>  -------------
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index 845661174..0d555ec29 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -319,8 +319,14 @@ static const struct rte_cryptodev_capabilities
> aesni_mb_pmd_capabilities[] = {
>  				},
>  				.iv_size = {
>  					.min = 16,
> +#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
> +					.max = 32,
> +					.increment = 16
> +#else

This should be done in "key_size", not iv_size.

Thanks,
Pablo
  

Patch

diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 6b1a7c58c..72d2f6c27 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -81,6 +81,11 @@  New Features
   by making use of the event device capabilities. The event mode currently supports
   only inline IPsec protocol offload.
 
+* **Updated the AESNI MB PMD.**
+
+  Updated the AESNI PMD with additional DOCSIS algorithm
+
+  * Added support for AES-256 DOCSIS
 
 Removed Items
 -------------
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 845661174..0d555ec29 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -319,8 +319,14 @@  static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
 				},
 				.iv_size = {
 					.min = 16,
+#if IMB_VERSION_NUM >= IMB_VERSION(0, 53, 3)
+					.max = 32,
+					.increment = 16
+#else
 					.max = 16,
 					.increment = 0
+#endif
+
 				}
 			}, }
 		}, }