diff mbox series

eal/ppc: add missing header inclusion

Message ID 20200417152516.21375-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series eal/ppc: add missing header inclusion |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation fail apply issues

Commit Message

David Marchand April 17, 2020, 3:25 p.m. UTC 
  Compilation is broken on ppc:

  CC otx2_rx.o
In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
.../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
error: expected declaration specifiers or ‘...’ before numeric constant
 } __rte_aligned(16) rte_xmm_t;
                 ^~
compilation terminated due to -Wfatal-errors.

Fixes: f35e5b3e07b2 ("replace alignment attributes")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_eal/ppc/include/rte_vect.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon April 17, 2020, 3:41 p.m. UTC | #1 
17/04/2020 17:25, David Marchand:
> Compilation is broken on ppc:
> 
>   CC otx2_rx.o
> In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
> .../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
> error: expected declaration specifiers or ‘...’ before numeric constant
>  } __rte_aligned(16) rte_xmm_t;
>                  ^~
> compilation terminated due to -Wfatal-errors.
> 
> Fixes: f35e5b3e07b2 ("replace alignment attributes")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Sorry for not having tested PPC.

About the title:
eal/ppc: fix missing include
or
eal/ppc: fix build
?

Tested-by: Thomas Monjalon <thomas@monjalon.net>
David Marchand April 17, 2020, 3:46 p.m. UTC | #2 
On Fri, Apr 17, 2020 at 5:41 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 17/04/2020 17:25, David Marchand:
> > Compilation is broken on ppc:
> >
> >   CC otx2_rx.o
> > In file included from .../drivers/net/octeontx2/otx2_rx.c:5:0:
> > .../builds/ppc_64-power8-linux-gcc/include/rte_vect.h:29:17:
> > error: expected declaration specifiers or ‘...’ before numeric constant
> >  } __rte_aligned(16) rte_xmm_t;
> >                  ^~
> > compilation terminated due to -Wfatal-errors.
> >
> > Fixes: f35e5b3e07b2 ("replace alignment attributes")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Sorry for not having tested PPC.
>
> About the title:
> eal/ppc: fix missing include
> or
> eal/ppc: fix build
> ?
>
> Tested-by: Thomas Monjalon <thomas@monjalon.net>

Applied.
David Christensen April 18, 2020, 10:20 p.m. UTC | #3 
> Compilation is broken on ppc:
What commit ID were you testing that failed to build?  This must be a 
recent change as I'm not seeing it on my system.

Dave
David Marchand April 19, 2020, 6:57 a.m. UTC | #4 
On Sun, Apr 19, 2020 at 12:20 AM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> > Compilation is broken on ppc:
> What commit ID were you testing that failed to build?  This must be a
> recent change as I'm not seeing it on my system.

The failure was seen at b11ecebc0.
diff mbox series

Patch

diff --git a/lib/librte_eal/ppc/include/rte_vect.h b/lib/librte_eal/ppc/include/rte_vect.h
index a0dabf02eb..1d6c29be02 100644
--- a/lib/librte_eal/ppc/include/rte_vect.h
+++ b/lib/librte_eal/ppc/include/rte_vect.h
@@ -7,7 +7,9 @@ 
 #define _RTE_VECT_PPC_64_H_
 
 #include <altivec.h>
+
 #include "generic/rte_vect.h"
+#include "rte_common.h"
 
 #ifdef __cplusplus
 extern "C" {