diff mbox series

[v8,1/9] net/virtio: add Rx free threshold setting

Message ID	20200423123106.78513-2-yong.liu@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Maxime Coquelin
Headers	IronPort-SDR: rg8Vt1QqJUCtvmUimqy/jIX4DbjbvEfgWsTiKIeyG64RZAN20ZA9o2pWiK6Iue+z8wkpnNUaxu 6Qpoa+bp84nw== IronPort-SDR: ER+TxvHP7UfMDvPGrhS7exf3ERYxLKRmPXFHbquor0MA0M8FW+a30Bg8Z7/wuLM+xBbRuLA7IR vcOEjSczqaJg== From: Marvin Liu <yong.liu@intel.com> To: maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com Cc: harry.van.haaren@intel.com, dev@dpdk.org, Marvin Liu <yong.liu@intel.com> Date: Thu, 23 Apr 2020 20:30:58 +0800 Message-Id: <20200423123106.78513-2-yong.liu@intel.com> In-Reply-To: <20200423123106.78513-1-yong.liu@intel.com> References: <20200313174230.74661-1-yong.liu@intel.com> <20200423123106.78513-1-yong.liu@intel.com> Subject: [dpdk-dev] [PATCH v8 1/9] net/virtio: add Rx free threshold setting Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add packed ring vectorized path \| [v8,0/9] add packed ring vectorized path [v8,1/9] net/virtio: add Rx free threshold setting [v8,2/9] net/virtio: enable vectorized path [v8,3/9] net/virtio: inorder should depend on feature bit [v8,4/9] net/virtio-user: add vectorized path parameter [v8,5/9] net/virtio: add vectorized packed ring Rx path [v8,6/9] net/virtio: reuse packed ring xmit functions [v8,7/9] net/virtio: add vectorized packed ring Tx path [v8,8/9] net/virtio: add election for vectorized path [v8,9/9] doc: add packed vectorized path

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/iol-intel-Performance	success	Performance Testing PASS
ci/iol-nxp-Performance	success	Performance Testing PASS
ci/iol-mellanox-Performance	success	Performance Testing PASS
ci/iol-testing	success	Testing PASS
ci/Intel-compilation	fail	Compilation issues

Commit Message

Marvin Liu April 23, 2020, 12:30 p.m. UTC

  Introduce free threshold setting in Rx queue, default value of it is 32.
Limiated threshold size to multiple of four as only vectorized packed Rx
function will utilize it. Virtio driver will rearm Rx queue when more
than rx_free_thresh descs were dequeued.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

Comments

Maxime Coquelin April 23, 2020, 8:09 a.m. UTC | #1

On 4/23/20 2:30 PM, Marvin Liu wrote:
> Introduce free threshold setting in Rx queue, default value of it is 32.
> Limiated threshold size to multiple of four as only vectorized packed Rx
s/Limiated/Limit the/

> function will utilize it. Virtio driver will rearm Rx queue when more
> than rx_free_thresh descs were dequeued.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

diff mbox series

Patch

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 060410577..94ba7a3ec 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -936,6 +936,7 @@  virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,
 	struct virtio_hw *hw = dev->data->dev_private;
 	struct virtqueue *vq = hw->vqs[vtpci_queue_idx];
 	struct virtnet_rx *rxvq;
+	uint16_t rx_free_thresh;
 
 	PMD_INIT_FUNC_TRACE();
 
@@ -944,6 +945,28 @@  virtio_dev_rx_queue_setup(struct rte_eth_dev *dev,
 		return -EINVAL;
 	}
 
+	rx_free_thresh = rx_conf->rx_free_thresh;
+	if (rx_free_thresh == 0)
+		rx_free_thresh =
+			RTE_MIN(vq->vq_nentries / 4, DEFAULT_RX_FREE_THRESH);
+
+	if (rx_free_thresh & 0x3) {
+		RTE_LOG(ERR, PMD, "rx_free_thresh must be multiples of four."
+			" (rx_free_thresh=%u port=%u queue=%u)\n",
+			rx_free_thresh, dev->data->port_id, queue_idx);
+		return -EINVAL;
+	}
+
+	if (rx_free_thresh >= vq->vq_nentries) {
+		RTE_LOG(ERR, PMD, "rx_free_thresh must be less than the "
+			"number of RX entries (%u)."
+			" (rx_free_thresh=%u port=%u queue=%u)\n",
+			vq->vq_nentries,
+			rx_free_thresh, dev->data->port_id, queue_idx);
+		return -EINVAL;
+	}
+	vq->vq_free_thresh = rx_free_thresh;
+
 	if (nb_desc == 0 || nb_desc > vq->vq_nentries)
 		nb_desc = vq->vq_nentries;
 	vq->vq_free_cnt = RTE_MIN(vq->vq_free_cnt, nb_desc);
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 58ad7309a..6301c56b2 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -18,6 +18,8 @@ 
 
 struct rte_mbuf;
 
+#define DEFAULT_RX_FREE_THRESH 32
+
 /*
  * Per virtio_ring.h in Linux.
  *     For virtio_pci on SMP, we don't need to order with respect to MMIO