diff mbox series

mem: fix build

Message ID 20200426104725.2809101-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers
Series mem: fix build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-mellanox-Performance fail Performance Testing issues
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/Intel-compilation fail apply issues

Commit Message

Thomas Monjalon April 26, 2020, 10:47 a.m. UTC 
  Some compilers (on RHEL7 and CentOS7) were getting this error:
	error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=undef]

Existence of a macro must be checked with "#ifdef" or "#if defined".

Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 lib/librte_eal/common/eal_common_memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Raslan Darawsheh April 26, 2020, 11 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Sunday, April 26, 2020 1:47 PM
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; Anatoly Burakov
> <anatoly.burakov@intel.com>; Li Feng <fengli@smartx.com>
> Subject: [dpdk-dev] [PATCH] mem: fix build
> 
> Some compilers (on RHEL7 and CentOS7) were getting this error:
> 	error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=undef]
> 
> Existence of a macro must be checked with "#ifdef" or "#if defined".
> 
> Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Raslan Darawsheh <rasland@mellanox.com>

> ---
>  lib/librte_eal/common/eal_common_memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/eal_common_memory.c
> b/lib/librte_eal/common/eal_common_memory.c
> index 9a797a4fa3..4c897a13f1 100644
> --- a/lib/librte_eal/common/eal_common_memory.c
> +++ b/lib/librte_eal/common/eal_common_memory.c
> @@ -42,7 +42,7 @@ static uint64_t system_page_sz;
> 
>  #ifdef RTE_EXEC_ENV_LINUX
>  #define RTE_DONTDUMP MADV_DONTDUMP
> -#elif RTE_EXEC_ENV_FREEBSD
> +#elif defined RTE_EXEC_ENV_FREEBSD
>  #define RTE_DONTDUMP MADV_NOCORE
>  #else
>  #error "madvise doesn't support this OS"
> --
> 2.26.0

Kindest regards
Raslan Darawsheh
Thomas Monjalon April 26, 2020, 11:27 a.m. UTC | #2 
> > Some compilers (on RHEL7 and CentOS7) were getting this error:
> > 	error: "RTE_EXEC_ENV_FREEBSD" is not defined [-Werror=undef]
> > 
> > Existence of a macro must be checked with "#ifdef" or "#if defined".
> > 
> > Fixes: d72e4042c5eb ("mem: exclude unused memory from core dump")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: Raslan Darawsheh <rasland@mellanox.com>

Applied
diff mbox series

Patch

diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index 9a797a4fa3..4c897a13f1 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -42,7 +42,7 @@  static uint64_t system_page_sz;
 
 #ifdef RTE_EXEC_ENV_LINUX
 #define RTE_DONTDUMP MADV_DONTDUMP
-#elif RTE_EXEC_ENV_FREEBSD
+#elif defined RTE_EXEC_ENV_FREEBSD
 #define RTE_DONTDUMP MADV_NOCORE
 #else
 #error "madvise doesn't support this OS"