diff mbox series

[v2] build: add note about make system deprecation

Message ID 20200427142520.22645-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] build: add note about make system deprecation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson April 27, 2020, 2:25 p.m. UTC 
  When anyone uses the make build system, they are to be informed
about upcoming plans to deprecate and subsequently remove that
system and to use meson and ninja instead.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

---
v2: added link to the docs on building DPDK
---
 mk/rte.sdkbuild.mk  | 5 +++++
 mk/rte.sdkconfig.mk | 5 +++++
 2 files changed, 10 insertions(+)

Comments

Ferruh Yigit April 27, 2020, 3:04 p.m. UTC | #1 
On 4/27/2020 3:25 PM, Bruce Richardson wrote:
> When anyone uses the make build system, they are to be informed
> about upcoming plans to deprecate and subsequently remove that
> system and to use meson and ninja instead.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Thomas Monjalon May 19, 2020, 4:05 p.m. UTC | #2 
27/04/2020 17:04, Ferruh Yigit:
> On 4/27/2020 3:25 PM, Bruce Richardson wrote:
> > When anyone uses the make build system, they are to be informed
> > about upcoming plans to deprecate and subsequently remove that
> > system and to use meson and ninja instead.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index b512de1ec..d1d57b669 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -28,6 +28,11 @@  CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
 .PHONY: build
 build: $(ROOTDIRS-y)
 	@echo "Build complete [$(RTE_TARGET)]"
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 
 .PHONY: clean
 clean: $(CLEANDIRS)
diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk
index f538649f2..2ea85e464 100644
--- a/mk/rte.sdkconfig.mk
+++ b/mk/rte.sdkconfig.mk
@@ -62,6 +62,11 @@  else
 config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile
 	@echo "Configuration done using" \
 		$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))
+	@echo "==== NOTE ===="
+	@echo "It is recommended to build DPDK using 'meson' and 'ninja'"
+	@echo "See https://doc.dpdk.org/guides/linux_gsg/build_dpdk.html for instructions"
+	@echo "Building DPDK with 'make' will be deprecated in a future release"
+	@echo "=============="
 endif
 
 $(RTE_OUTPUT):