diff mbox series

[2/7] build: remove unnecessary variable

Message ID 20200429100831.398-3-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series improve DPDK static builds with meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson April 29, 2020, 10:08 a.m. UTC 
  Since all libraries are explicitly linked as part of a build, we no longer
need to track ones that should be always included for linking against apps.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/meson.build                  | 2 +-
 lib/librte_telemetry/meson.build | 1 -
 meson.build                      | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

Comments

Thomas Monjalon April 29, 2020, 10:19 a.m. UTC | #1 
29/04/2020 12:08, Bruce Richardson:
> Since all libraries are explicitly linked as part of a build, we no longer
> need to track ones that should be always included for linking against apps.

I don't understand why telemetry was managed differently.
Bruce Richardson April 29, 2020, 10:29 a.m. UTC | #2 
O Wed, Apr 29, 2020 at 12:19:38PM +0200, Thomas Monjalon wrote:
> 29/04/2020 12:08, Bruce Richardson:
> > Since all libraries are explicitly linked as part of a build, we no longer
> > need to track ones that should be always included for linking against apps.
> 
> I don't understand why telemetry was managed differently.
> 
Because it was never directly called by applications - and so unneeded from
the linkers viewpoint - but still needed to be linked in to allow apps to
support emitting telemetry data. Therefore it was needed to add it
explicitly because it was never in the required dependency list for each
app.

This wasn't needed for make, since all libs were always linked into make
builds. The previous patch in this set changes meson to behave that way
too.

/Bruce
diff mbox series

Patch

diff --git a/app/meson.build b/app/meson.build
index 0f7fe9464..25f2da82e 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -36,7 +36,7 @@  foreach app:apps
 	# use "deps" for internal DPDK dependencies, and "ext_deps" for
 	# external package/library requirements
 	ext_deps = []
-	deps = dpdk_app_link_libraries
+	deps = []
 
 	subdir(name)
 
diff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build
index 1bdf128c1..c6e8cc5de 100644
--- a/lib/librte_telemetry/meson.build
+++ b/lib/librte_telemetry/meson.build
@@ -8,7 +8,6 @@  deps += ['metrics', 'ethdev']
 jansson = dependency('jansson', required: false)
 if jansson.found()
 	ext_deps += jansson
-	dpdk_app_link_libraries += ['telemetry']
 else
 	build = false
 	reason = 'missing dependency "jansson"'
diff --git a/meson.build b/meson.build
index d36580438..d8504afbf 100644
--- a/meson.build
+++ b/meson.build
@@ -19,7 +19,6 @@  dpdk_static_libraries = []
 dpdk_driver_classes = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
-dpdk_app_link_libraries = []
 dpdk_libs_disabled = []
 dpdk_drvs_disabled = []
 abi_version_file = files('ABI_VERSION')