diff mbox series

[7/7] build/pkg-config: prevent overlinking

Message ID 20200429100831.398-8-bruce.richardson@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series improve DPDK static builds with meson |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Bruce Richardson April 29, 2020, 10:08 a.m. UTC 
  Add the --as-needed linker flag to the DPDK library list in the pkg-config
file so as to prevent overlinking. Without this flag, when linking
statically using flags from $(pkg-config --static --libs libdpdk), all DPDK
drivers and libs were statically linked in, but the binary was also
requiring all the shared versions be present to run.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 buildtools/pkg-config/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Monjalon April 29, 2020, 10:34 a.m. UTC | #1 
29/04/2020 12:08, Bruce Richardson:
> Add the --as-needed linker flag to the DPDK library list in the pkg-config
> file so as to prevent overlinking. Without this flag, when linking
> statically using flags from $(pkg-config --static --libs libdpdk), all DPDK
> drivers and libs were statically linked in, but the binary was also
> requiring all the shared versions be present to run.

I consider "--as-needed" as a workaround here.
The root issue is that pkg-config does not distinguish clearly
shared and static linkage, right?
Bruce Richardson April 29, 2020, 11 a.m. UTC | #2 
On Wed, Apr 29, 2020 at 12:34:56PM +0200, Thomas Monjalon wrote:
> 29/04/2020 12:08, Bruce Richardson:
> > Add the --as-needed linker flag to the DPDK library list in the pkg-config
> > file so as to prevent overlinking. Without this flag, when linking
> > statically using flags from $(pkg-config --static --libs libdpdk), all DPDK
> > drivers and libs were statically linked in, but the binary was also
> > requiring all the shared versions be present to run.
> 
> I consider "--as-needed" as a workaround here.
> The root issue is that pkg-config does not distinguish clearly
> shared and static linkage, right?
> 
Yeah, pretty much. Improved static linking support in pkg-config would
really help with all this - and probably make much of this set unnecessary.
Unfortunately, how pkg-config works right now is how it works, and a change
to support what we want would be a fairly major change in functionality.

/Bruce
diff mbox series

Patch

diff --git a/buildtools/pkg-config/meson.build b/buildtools/pkg-config/meson.build
index bc723317c..07b556288 100644
--- a/buildtools/pkg-config/meson.build
+++ b/buildtools/pkg-config/meson.build
@@ -22,7 +22,7 @@  pkg.generate(name: 'dpdk-libs',
 	version: meson.project_version(),
 	subdirs: [get_option('include_subdir_arch'), '.'],
 	extra_cflags: pkg_extra_cflags,
-	libraries: dpdk_libraries,
+	libraries: ['-Wl,--as-needed'] + dpdk_libraries,
 	libraries_private: dpdk_extra_ldflags)
 
 pkg.generate(name: 'DPDK', # main DPDK pkgconfig file