diff mbox series

net/octeontx2: offload bad L4 checksum detection

Message ID 1588326809-17372-1-git-send-email-agupta3@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series net/octeontx2: offload bad L4 checksum detection |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

Amit Gupta May 1, 2020, 9:53 a.m. UTC 
  From: Amit Gupta <agupta3@marvell.com>

On detecting outer L4 checksum as bad, both outer and
inner checksums are marked as bad. No need to explicitly
check inner L4 checksum in this case.

Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
and PKT_RX_L4_CKSUM_BAD

Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD

Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection")

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
 drivers/net/octeontx2/otx2_lookup.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jerin Jacob May 4, 2020, 7:59 a.m. UTC | #1 
On Fri, May 1, 2020 at 3:23 PM <agupta3@marvell.com> wrote:
>
> From: Amit Gupta <agupta3@marvell.com>
>
> On detecting outer L4 checksum as bad, both outer and
> inner checksums are marked as bad. No need to explicitly
> check inner L4 checksum in this case.
>
> Outer L4 UDP checksum error => PKT_RX_OUTER_L4_CKSUM_BAD
> and PKT_RX_L4_CKSUM_BAD
>
> Inner L4 UDP checksum error => PKT_RX_L4_CKSUM_BAD
>
> Fixes: 41fe7a3a11fd ("net/octeontx2: offload bad L2/L3/L4 UDP lengths detection")
>
> Signed-off-by: Amit Gupta <agupta3@marvell.com>

Changed the subject to: net/octeontx2: fix offload bad L4 checksum detection

Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied to dpdk-next-net-mrvl/master. Thanks




> ---
>  drivers/net/octeontx2/otx2_lookup.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
> index 9dcfc75..10944bc 100644
> --- a/drivers/net/octeontx2/otx2_lookup.c
> +++ b/drivers/net/octeontx2/otx2_lookup.c
> @@ -301,6 +301,7 @@
>                             errcode == NIX_RX_PERRCODE_OL4_LEN ||
>                             errcode == NIX_RX_PERRCODE_OL4_PORT) {
>                                 val |= PKT_RX_IP_CKSUM_GOOD;
> +                               val |= PKT_RX_L4_CKSUM_BAD;
>                                 val |= PKT_RX_OUTER_L4_CKSUM_BAD;
>                         } else if (errcode == NIX_RX_PERRCODE_IL4_CHK ||
>                                    errcode == NIX_RX_PERRCODE_IL4_LEN ||
> --
> 1.8.3.1
>
diff mbox series

Patch

diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c
index 9dcfc75..10944bc 100644
--- a/drivers/net/octeontx2/otx2_lookup.c
+++ b/drivers/net/octeontx2/otx2_lookup.c
@@ -301,6 +301,7 @@ 
 			    errcode == NIX_RX_PERRCODE_OL4_LEN ||
 			    errcode == NIX_RX_PERRCODE_OL4_PORT) {
 				val |= PKT_RX_IP_CKSUM_GOOD;
+				val |= PKT_RX_L4_CKSUM_BAD;
 				val |= PKT_RX_OUTER_L4_CKSUM_BAD;
 			} else if (errcode == NIX_RX_PERRCODE_IL4_CHK ||
 				   errcode == NIX_RX_PERRCODE_IL4_LEN ||