diff mbox series

[v3] doc: use glob terminology

Message ID 20200504134537.3683158-1-jerinj@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v3] doc: use glob terminology |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

Jerin Jacob Kollanukkaran May 4, 2020, 1:45 p.m. UTC 
  From: Jerin Jacob <jerinj@marvell.com>

Glob is the terminology used in fnmatch man page.
Use glob terminology across DPDK for shell pattern.

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---

v3:
- Address Thomas's comments
http://patches.dpdk.org/patch/68225/

v2:
- Fix typo

 devtools/check-includes.sh             | 2 +-
 lib/librte_eal/common/eal_common_log.c | 4 ++--
 lib/librte_eal/include/rte_log.h       | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

--
2.26.2

Comments

Thomas Monjalon May 19, 2020, 2:05 p.m. UTC | #1 
04/05/2020 15:45, jerinj@marvell.com:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> Glob is the terminology used in fnmatch man page.
> Use glob terminology across DPDK for shell pattern.
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
> 
> v3:
> - Address Thomas's comments
> http://patches.dpdk.org/patch/68225/

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks
diff mbox series

Patch

diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh
index 3629ab4c7..749b9b26d 100755
--- a/devtools/check-includes.sh
+++ b/devtools/check-includes.sh
@@ -23,7 +23,7 @@ 
 # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
 # C/C++ compilation flags.
 #
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of globbing patterns matching files (relative to the
 # include directory) to avoid. It is set by default to known DPDK headers
 # which must not be included on their own.
 #
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index d7a5f9b64..8835c8fff 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -29,7 +29,7 @@  struct rte_eal_opt_loglevel {
 	TAILQ_ENTRY(rte_eal_opt_loglevel) next;
 	/** Compiled regular expression obtained from the option */
 	regex_t re_match;
-	/** Glob match string option */
+	/** Globbing pattern option */
 	char *pattern;
 	/** Log level value obtained from the option */
 	uint32_t level;
@@ -207,7 +207,7 @@  int rte_log_save_regexp(const char *regex, int tmp)
 	return rte_log_save_level(tmp, regex, NULL);
 }

-/* set log level based on glob (file match) pattern */
+/* set log level based on globbing pattern */
 int
 rte_log_set_level_pattern(const char *pattern, uint32_t level)
 {
diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
index c020a3d7e..1789ede56 100644
--- a/lib/librte_eal/include/rte_log.h
+++ b/lib/librte_eal/include/rte_log.h
@@ -158,10 +158,10 @@  __rte_experimental
 bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);

 /**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on globbing pattern.
  *
  * @param pattern
- *   The match pattern identifying the log type.
+ *   The globbing pattern identifying the log type.
  * @param level
  *   The level to be set.
  * @return