[v2,2/2] eal: add log support on Windows
Checks
Commit Message
Initialize logging on Windows to send log output
to the console.
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
Reviewed-by: Tasnim Bashar <tbashar@mellanox.com>
Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
lib/librte_eal/windows/eal.c | 3 +++
lib/librte_eal/windows/eal_log.c | 16 ++++++++++++++++
lib/librte_eal/windows/meson.build | 1 +
3 files changed, 20 insertions(+)
create mode 100644 lib/librte_eal/windows/eal_log.c
Comments
On Tue, May 05, 2020 at 06:30:32PM -0700, Pallavi Kadam wrote:
> Initialize logging on Windows to send log output
> to the console.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> Reviewed-by: Tasnim Bashar <tbashar@mellanox.com>
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>
06/05/2020 03:30, Pallavi Kadam:
> Initialize logging on Windows to send log output
> to the console.
>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> Reviewed-by: Tasnim Bashar <tbashar@mellanox.com>
> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
The comment below is useless. I take freedom of dropping it on apply :-)
> + /* initialize all logs */
> + rte_eal_log_init(NULL, 0);
@@ -227,6 +227,9 @@ rte_eal_init(int argc, char **argv)
{
int i, fctret;
+ /* initialize all logs */
+ rte_eal_log_init(NULL, 0);
+
eal_log_level_parse(argc, argv);
/* create a map of all processors in the system */
new file mode 100644
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2017-2018 Intel Corporation
+ */
+
+#include "eal_private.h"
+
+/* set the log to default function, called during eal init process. */
+int
+rte_eal_log_init(__rte_unused const char *id, __rte_unused int facility)
+{
+ rte_openlog_stream(stderr);
+
+ eal_log_set_default(stderr);
+
+ return 0;
+}
@@ -7,6 +7,7 @@ sources += files(
'eal.c',
'eal_debug.c',
'eal_lcore.c',
+ 'eal_log.c',
'eal_thread.c',
'fnmatch.c',
'getopt.c',