diff mbox series

[3/5] telemetry: fix closing socket fd on error

Message ID 20200512152902.70211-4-ciara.power@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series small fixes for telemetry rework. |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Power, Ciara May 12, 2020, 3:29 p.m. UTC 
  The socket fd is now being closed when the connection fails.

Coverity issue: 358444
Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
Cc: ciara.power@intel.com

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 lib/librte_telemetry/telemetry_legacy.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Kevin Laatz May 18, 2020, 2:52 p.m. UTC | #1 
On 12/05/2020 16:29, Ciara Power wrote:
> The socket fd is now being closed when the connection fails.
>
> Coverity issue: 358444
> Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")
> Cc: ciara.power@intel.com
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>   lib/librte_telemetry/telemetry_legacy.c | 1 +
>   1 file changed, 1 insertion(+)
>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
diff mbox series

Patch

diff --git a/lib/librte_telemetry/telemetry_legacy.c b/lib/librte_telemetry/telemetry_legacy.c
index 10b575adfd..72471cbfbe 100644
--- a/lib/librte_telemetry/telemetry_legacy.c
+++ b/lib/librte_telemetry/telemetry_legacy.c
@@ -100,6 +100,7 @@  register_client(const char *cmd __rte_unused, const char *params,
 
 	if (connect(fd, (struct sockaddr *)&addrs, sizeof(addrs)) == -1) {
 		perror("\nClient connection error\n");
+		close(fd);
 		return -1;
 	}
 	pthread_create(&th, NULL, &legacy_client_handler,