diff mbox series

crypto/virtio: add OOP_LB_IN_LB_OUT feature flag

Message ID 20200515093127.1471-1-jianjay.zhou@huawei.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/virtio: add OOP_LB_IN_LB_OUT feature flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing fail Testing issues

Commit Message

Zhoujian (jay) May 15, 2020, 9:31 a.m. UTC 
  Since it will check the feature mask before running out-of-place
test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.

Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
---
 drivers/crypto/virtio/virtio_cryptodev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Akhil Goyal May 15, 2020, 5:07 p.m. UTC | #1 
Hi Jay,


> 
> Since it will check the feature mask before running out-of-place
> test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> 
Is this feature already supported in the PMD and this patch is a fix to the original patch.
If that is the case, title should be
Crypto/virtio: add missing OOP feature flag
Also add a fixes line to link the original feature patch.

> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
Akhil Goyal May 17, 2020, 1:18 p.m. UTC | #2 
> 
> Hi Jay,
> 
> 
> >
> > Since it will check the feature mask before running out-of-place
> > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> >
> Is this feature already supported in the PMD and this patch is a fix to the original
> patch.
> If that is the case, title should be
> Crypto/virtio: add missing OOP feature flag
> Also add a fixes line to link the original feature patch.
> 
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---

The feature is also not added in the documentation
doc/guides/cryptodevs/features/virtio.ini
Akhil Goyal May 17, 2020, 2:17 p.m. UTC | #3 
> 
> >
> > Hi Jay,
> >
> >
> > >
> > > Since it will check the feature mask before running out-of-place
> > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> > >
> > Is this feature already supported in the PMD and this patch is a fix to the
> original
> > patch.
> > If that is the case, title should be
> > Crypto/virtio: add missing OOP feature flag
> > Also add a fixes line to link the original feature patch.
> >
> > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > ---
> 
> The feature is also not added in the documentation
> doc/guides/cryptodevs/features/virtio.ini
> 

I have done the required changes myself while merging the patch as we
Need to close the tree for RC3.
Please have a look.

Thanks.
Zhoujian (jay) May 18, 2020, 1:03 a.m. UTC | #4 
Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Saturday, May 16, 2020 1:08 AM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature flag
> 
> Hi Jay,
> 
> 
> >
> > Since it will check the feature mask before running out-of-place test
> > cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> >
> Is this feature already supported in the PMD and this patch is a fix to the original
> patch.

Yes.

> If that is the case, title should be
> Crypto/virtio: add missing OOP feature flag Also add a fixes line to link the original
> feature patch.

The OOP_LB_IN_LB_OUT function is introduced by commit 82adb12a 
(crypto/virtio: support burst enqueue/dequeue), but the OOP_LB_IN_LB_OUT
feature flag is introduced after that, which is commit 2717246e
(cryptodev: replace mbuf scatter gather flag), I'm not sure which one should be added.

Regards,
Jay Zhou

> 
> > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > ---
Zhoujian (jay) May 18, 2020, 1:07 a.m. UTC | #5 
> -----Original Message-----
> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> Sent: Sunday, May 17, 2020 10:18 PM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; Huangweidong
> (C) <weidong.huang@huawei.com>
> Subject: RE: [dpdk-dev] [PATCH] crypto/virtio: add OOP_LB_IN_LB_OUT feature
> flag
> 
> >
> > >
> > > Hi Jay,
> > >
> > >
> > > >
> > > > Since it will check the feature mask before running out-of-place
> > > > test cases and the virtio-crypto device supports OOP_LB_IN_LB_OUT mode.
> > > >
> > > Is this feature already supported in the PMD and this patch is a fix
> > > to the
> > original
> > > patch.
> > > If that is the case, title should be
> > > Crypto/virtio: add missing OOP feature flag Also add a fixes line to
> > > link the original feature patch.
> > >
> > > > Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> > > > ---
> >
> > The feature is also not added in the documentation
> > doc/guides/cryptodevs/features/virtio.ini
> >

Oh, Yes.

> 
> I have done the required changes myself while merging the patch as we Need to
> close the tree for RC3.
> Please have a look.

Thanks for helping to do it. BTW, should we add the "Fixes:" line in the patch?

Regards,
Jay Zhou
diff mbox series

Patch

diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
index e7fb71a..cdf43b0 100644
--- a/drivers/crypto/virtio/virtio_cryptodev.c
+++ b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -741,7 +741,8 @@  static int virtio_crypto_sym_configure_session(struct rte_cryptodev *dev,
 	cryptodev->dequeue_burst = virtio_crypto_pkt_rx_burst;
 
 	cryptodev->feature_flags = RTE_CRYPTODEV_FF_SYMMETRIC_CRYPTO |
-		RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING;
+		RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
+		RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;
 
 	hw = cryptodev->data->dev_private;
 	hw->dev_id = cryptodev->data->dev_id;