diff mbox series

net/iavf: fix FDIR ID parsing issue after queue reconfigured

Message ID 20200520063950.50315-1-leyi.rong@intel.com (mailing list archive)
State Accepted, archived
Delegated to: xiaolong ye
Headers
Series net/iavf: fix FDIR ID parsing issue after queue reconfigured |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/Intel-compilation fail Compilation issues
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Leyi Rong May 20, 2020, 6:39 a.m. UTC 
  FDIR ID parsing will not be handled correctly after queue reconfigured,
enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.

Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")

Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
 drivers/net/iavf/iavf_rxtx.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Xiaolong Ye May 20, 2020, 7:10 a.m. UTC | #1 
On 05/20, Leyi Rong wrote:
>FDIR ID parsing will not be handled correctly after queue reconfigured,
>enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.
>
>Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")
>
>Signed-off-by: Leyi Rong <leyi.rong@intel.com>
>---
> drivers/net/iavf/iavf_rxtx.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
>index 73968847f..59625a979 100644
>--- a/drivers/net/iavf/iavf_rxtx.h
>+++ b/drivers/net/iavf/iavf_rxtx.h
>@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)
> {
> 	if (on) {
> 		/* enable flow director processing */
>-		if (ad->fdir_ref_cnt++ == 0)
>-			FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+		FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
>+		ad->fdir_ref_cnt++;
> 	} else {
> 		if (ad->fdir_ref_cnt >= 1) {
> 			ad->fdir_ref_cnt--;
>-- 
>2.17.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel, Thanks.
Peng, Yuan May 20, 2020, 7:56 a.m. UTC | #2 
Test-by Peng, Yuan <yuan.peng@intel.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of Leyi Rong
Sent: Wednesday, May 20, 2020 2:40 PM
To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
Cc: dev@dpdk.org; Rong, Leyi <leyi.rong@intel.com>
Subject: [dpdk-dev] [PATCH] net/iavf: fix FDIR ID parsing issue after queue reconfigured

FDIR ID parsing will not be handled correctly after queue reconfigured, enable FDIR ID parsing per Q regardless of fdir_ref_cnt to fix it.

Fixes: f71dbf852d46 ("net/iavf: add flow director enabled switch value")

Signed-off-by: Leyi Rong <leyi.rong@intel.com>
---
 drivers/net/iavf/iavf_rxtx.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 73968847f..59625a979 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -509,8 +509,8 @@ void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)  {
 	if (on) {
 		/* enable flow director processing */
-		if (ad->fdir_ref_cnt++ == 0)
-			FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+		FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+		ad->fdir_ref_cnt++;
 	} else {
 		if (ad->fdir_ref_cnt >= 1) {
 			ad->fdir_ref_cnt--;
--
2.17.1
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h
index 73968847f..59625a979 100644
--- a/drivers/net/iavf/iavf_rxtx.h
+++ b/drivers/net/iavf/iavf_rxtx.h
@@ -509,8 +509,8 @@  void iavf_fdir_rx_proc_enable(struct iavf_adapter *ad, bool on)
 {
 	if (on) {
 		/* enable flow director processing */
-		if (ad->fdir_ref_cnt++ == 0)
-			FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+		FDIR_PROC_ENABLE_PER_QUEUE(ad, on);
+		ad->fdir_ref_cnt++;
 	} else {
 		if (ad->fdir_ref_cnt >= 1) {
 			ad->fdir_ref_cnt--;