diff mbox series

lib/librte_net: fix bug for ipv4 checksum calculating

Message ID 20200526091639.17640-1-guohongzhi1@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series lib/librte_net: fix bug for ipv4 checksum calculating |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/travis-robot success Travis build: passed

Commit Message

Hongzhi Guo May 26, 2020, 9:16 a.m. UTC 
  0xffff is invalid for IPv4 checksum(RFC1624)

Fixes: 6006818cfb26 ("net: new checksum functions")

Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Signed-off-by: guohongzhi <guohongzhi1@huawei.com>
---
 lib/librte_net/rte_ip.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Morten Brørup May 26, 2020, 9:31 a.m. UTC | #1 
guohongzhi,

You must use your real name in the Signed-off-by line.

The signoff must be a real name and not an alias or nickname. For further details, please refer to: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1


Med venlig hilsen / kind regards
- Morten Brørup

> -----Original Message-----
> From: guohongzhi [mailto:guohongzhi1@huawei.com]
> Sent: Tuesday, May 26, 2020 11:17 AM
> To: dev@dpdk.org
> Cc: olivier.matz@6wind.com; Morten Brørup;
> konstantin.ananyev@intel.com; jiayu.hu@intel.com;
> ferruh.yigit@intel.com; nicolas.chautru@intel.com;
> cristian.dumitrescu@intel.com; zhoujingbin@huawei.com;
> chenchanghu@huawei.com; jerry.lilijun@huawei.com;
> haifeng.lin@huawei.com; guohongzhi1@huawei.com
> Subject: [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating
> 
> 0xffff is invalid for IPv4 checksum(RFC1624)
> 
> Fixes: 6006818cfb26 ("net: new checksum functions")
> 
> Reviewed-By: Morten Brørup <mb@smartsharesystems.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Signed-off-by: guohongzhi <guohongzhi1@huawei.com>
> ---
>  lib/librte_net/rte_ip.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
> index 1ceb7b7..ece2e43 100644
> --- a/lib/librte_net/rte_ip.h
> +++ b/lib/librte_net/rte_ip.h
> @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
>  {
>  	uint16_t cksum;
>  	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
> -	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
> +	return (uint16_t)~cksum;
>  }
> 
>  /**
> --
> 2.21.0.windows.1
> 
>
diff mbox series

Patch

diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h
index 1ceb7b7..ece2e43 100644
--- a/lib/librte_net/rte_ip.h
+++ b/lib/librte_net/rte_ip.h
@@ -267,7 +267,7 @@  rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)
 {
 	uint16_t cksum;
 	cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr));
-	return (cksum == 0xffff) ? cksum : (uint16_t)~cksum;
+	return (uint16_t)~cksum;
 }
 
 /**