diff mbox series

[5/7] crypto/octeontx: remove unsupported feature

Message ID 1591853907-2501-6-git-send-email-adwivedi@marvell.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series test/crypto: use generic crypto auto test framework |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ankur Dwivedi June 11, 2020, 5:38 a.m. UTC 
  For SNOW and ZUC algos the offset value for enryption and decryption
is converted to bytes. Hence RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA
feature is not supported by the octeontx crypto pmd.

Fixes: 32b8f26adf8b ("crypto/octeontx: enable non-byte aligned data")

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
 doc/guides/cryptodevs/features/octeontx.ini | 1 -
 drivers/crypto/octeontx/otx_cryptodev_ops.c | 1 -
 2 files changed, 2 deletions(-)

Comments

Akhil Goyal July 1, 2020, 8:27 p.m. UTC | #1 
Hi,

> Subject: [PATCH 5/7] crypto/octeontx: remove unsupported feature
> 
> For SNOW and ZUC algos the offset value for enryption and decryption
> is converted to bytes. Hence RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA
> feature is not supported by the octeontx crypto pmd.
> 
> Fixes: 32b8f26adf8b ("crypto/octeontx: enable non-byte aligned data")
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---
This patch is actually reverting the original patch.
So probably you should create a revert commit 
And also cc stable.

Same comment for 6/7 patch.
Ankur Dwivedi July 2, 2020, 1:20 p.m. UTC | #2 
Hi Akhil,

Please see my response inline.

Thanks
Ankur

>-----Original Message-----
>From: Akhil Goyal <akhil.goyal@nxp.com>
>Sent: Thursday, July 2, 2020 1:57 AM
>To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
>Cc: declan.doherty@intel.com; Anoob Joseph <anoobj@marvell.com>
>Subject: [EXT] RE: [PATCH 5/7] crypto/octeontx: remove unsupported feature
>
>External Email
>
>----------------------------------------------------------------------
>Hi,
>
>> Subject: [PATCH 5/7] crypto/octeontx: remove unsupported feature
>>
>> For SNOW and ZUC algos the offset value for enryption and decryption
>> is converted to bytes. Hence
>RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA
>> feature is not supported by the octeontx crypto pmd.
>>
>> Fixes: 32b8f26adf8b ("crypto/octeontx: enable non-byte aligned data")
>>
>> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
>> ---
>This patch is actually reverting the original patch.
>So probably you should create a revert commit And also cc stable.
>
>Same comment for 6/7 patch.
[Ankur] Will address these in v2.
diff mbox series

Patch

diff --git a/doc/guides/cryptodevs/features/octeontx.ini b/doc/guides/cryptodevs/features/octeontx.ini
index 09affb2..4ce4ff1 100644
--- a/doc/guides/cryptodevs/features/octeontx.ini
+++ b/doc/guides/cryptodevs/features/octeontx.ini
@@ -13,7 +13,6 @@  OOP SGL In LB  Out     = Y
 OOP SGL In SGL Out     = Y
 RSA PRIV OP KEY QT     = Y
 Symmetric sessionless  = Y
-Non-Byte aligned data  = Y
 
 ;
 ; Supported crypto algorithms of 'octeontx' crypto driver.
diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c
index 8f58fe2..2cedf7d 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
@@ -979,7 +979,6 @@ 
 				RTE_CRYPTODEV_FF_IN_PLACE_SGL |
 				RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
 				RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
-				RTE_CRYPTODEV_FF_NON_BYTE_ALIGNED_DATA |
 				RTE_CRYPTODEV_FF_SYM_SESSIONLESS;
 		break;
 	default: