diff mbox series

rte_sched: fix 64-bit support in rate functions

Message ID 20200615171905.5377-1-hrvoje.habjanic@zg.ht.hr (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series rte_sched: fix 64-bit support in rate functions |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Hrvoje Habjanic June 15, 2020, 5:19 p.m. UTC 
  Functions rte_sched_subport_config_pipe_profile_table and
pipe_profile_check should also have increased rate
arguments.

Fixes: 68c1f26d4236 (\"sched: support 64-bit values\")
Cc: jasvinder.singh@intel.com

Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
---
 lib/librte_sched/rte_sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jasvinder Singh June 16, 2020, 11:52 a.m. UTC | #1 
> -----Original Message-----
> From: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> Sent: Monday, June 15, 2020 6:19 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] rte_sched: fix 64-bit support in rate functions
> 
> Functions rte_sched_subport_config_pipe_profile_table and
> pipe_profile_check should also have increased rate arguments.
> 
> Fixes: 68c1f26d4236 (\"sched: support 64-bit values\")
> Cc: jasvinder.singh@intel.com
> 
> Signed-off-by: Hrvoje Habjanic <hrvoje.habjanic@zg.ht.hr>
> ---
>  lib/librte_sched/rte_sched.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> c0983ddda..be822057b 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port
> *port, uint32_t qindex)
> 
>  static int
>  pipe_profile_check(struct rte_sched_pipe_params *params,
> -	uint32_t rate, uint16_t *qsize)
> +	uint64_t rate, uint16_t *qsize)
>  {
>  	uint32_t i;
> 
> @@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct
> rte_sched_subport *subport,
> 
>  static void
>  rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport
> *subport,
> -	struct rte_sched_subport_params *params, uint32_t rate)
> +	struct rte_sched_subport_params *params, uint64_t rate)
>  {
>  	uint32_t i;
> 

Hi Hrvoje,

Thanks for sending the patch. Few days ago, similar fix was proposed https://www.mail-archive.com/dev@dpdk.org/msg168579.html 
which I acked. I think that patch is not applied on DPDK yet but will happen soon. 

Regards,
Jasvinder
diff mbox series

Patch

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index c0983ddda..be822057b 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -304,7 +304,7 @@  rte_sched_port_tc_queue(struct rte_sched_port *port, uint32_t qindex)
 
 static int
 pipe_profile_check(struct rte_sched_pipe_params *params,
-	uint32_t rate, uint16_t *qsize)
+	uint64_t rate, uint16_t *qsize)
 {
 	uint32_t i;
 
@@ -624,7 +624,7 @@  rte_sched_pipe_profile_convert(struct rte_sched_subport *subport,
 
 static void
 rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport *subport,
-	struct rte_sched_subport_params *params, uint32_t rate)
+	struct rte_sched_subport_params *params, uint64_t rate)
 {
 	uint32_t i;