net/nfp: fix RSS hash configuration reporting
Checks
Commit Message
Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get
callback did not propagate the current hardware state of rss_hf back up
to the caller. Users of the hash_conf_get callback would receive an
incorrect representation of what the RSS configuration currently is in
hardware.
Fixes: 934e4c60fbff ("nfp: add RSS")
Cc: stable@dpdk.org
Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
drivers/net/nfp/nfp_net.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On 7/10/2020 3:28 PM, Heinrich Kuhn wrote:
> Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get
> callback did not propagate the current hardware state of rss_hf back up
> to the caller. Users of the hash_conf_get callback would receive an
> incorrect representation of what the RSS configuration currently is in
> hardware.
>
> Fixes: 934e4c60fbff ("nfp: add RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Applied to dpdk-next-net/master, thanks.
@@ -2626,6 +2626,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,
if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6)
rss_hf |= ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP;
+ /* Propagate current RSS hash functions to caller */
+ rss_conf->rss_hf = rss_hf;
+
/* Reading the key size */
rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);