[v1] net/ice: fix ipv6 nat-t esp issue

Message ID 20200716072900.56141-1-jia.guo@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v1] net/ice: fix ipv6 nat-t esp issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Guo, Jia July 16, 2020, 7:29 a.m. UTC
  The hash for ipv6 nat-t esp should be enable as ipv4 nat-t esp.

Fixes: dadf70e5c30a (net/ice: enable additional input set for RSS hash)

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 drivers/net/ice/ice_hash.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
  

Comments

Qi Zhang July 16, 2020, 9:20 a.m. UTC | #1
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Thursday, July 16, 2020 3:29 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Su, Simei <simei.su@intel.com>; Guo, Jia
> <jia.guo@intel.com>
> Subject: [dpdk-dev v1] net/ice: fix ipv6 nat-t esp issue
> 
> The hash for ipv6 nat-t esp should be enable as ipv4 nat-t esp.
> 
> Fixes: dadf70e5c30a (net/ice: enable additional input set for RSS hash)
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
  

Patch

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index af29ab6c9..05388b412 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -1102,7 +1102,8 @@  ice_hash_parse_action(struct ice_pattern_match_item *pattern_match_item,
 
 			/* update hash field for nat-t esp. */
 			if (rss_type == ETH_RSS_ESP &&
-			    (m->eth_rss_hint & ETH_RSS_NONFRAG_IPV4_UDP)) {
+			    (m->eth_rss_hint & ETH_RSS_NONFRAG_IPV4_UDP ||
+			     m->eth_rss_hint & ETH_RSS_NONFRAG_IPV6_UDP)) {
 				hash_meta->hash_flds &=
 				~(BIT_ULL(ICE_FLOW_FIELD_IDX_ESP_SPI));
 				hash_meta->hash_flds |=