diff mbox series

[v2] net/ice: fix incorrect firmware version

Message ID 20200806102824.2561-1-shougangx.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series [v2] net/ice: fix incorrect firmware version |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Shougang Wang Aug. 6, 2020, 10:28 a.m. UTC 
  Kernel driver shows firmware version as hex but ice PMD shows
as decimal. This patch fixes the issue to make consistent with
kernel driver.

Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
Cc: stable@dpdk.org

Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
---
v2:
corrected fixes version
---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qiming Yang Aug. 7, 2020, 1:45 a.m. UTC | #1 
> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Thursday, August 6, 2020 18:28
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
> v2:
> corrected fixes version
> ---
>  drivers/net/ice/ice_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8d435e889..88b8428b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char
> *fw_version, size_t fw_size)
>  	build = hw->nvm.orom.build;
> 
>  	ret = snprintf(fw_version, fw_size,
> -			"%d.%d 0x%08x %d.%d.%d",
> +			"%x.%02x 0x%08x %d.%d.%d",
>  			hw->nvm.major_ver,
>  			hw->nvm.minor_ver,
>  			hw->nvm.eetrack,
> --
> 2.17.1

Acked-by: Qiming Yang <qiming.yang@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..88b8428b9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4388,7 +4388,7 @@  ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	build = hw->nvm.orom.build;
 
 	ret = snprintf(fw_version, fw_size,
-			"%d.%d 0x%08x %d.%d.%d",
+			"%x.%02x 0x%08x %d.%d.%d",
 			hw->nvm.major_ver,
 			hw->nvm.minor_ver,
 			hw->nvm.eetrack,