diff mbox series

[v2] doc: announce removal of interactive setup script

Message ID 20200806145150.3529482-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers
Series [v2] doc: announce removal of interactive setup script |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

Thomas Monjalon Aug. 6, 2020, 2:51 p.m. UTC 
  Environment configuration is the responsibility of distributions
or upper-level frameworks.
DPDK focus on documenting the requirements and some recommendations.
If some specific parts are complex, they can deserve some scripts.

Maintaining a good adaptative deployment setup is a project by itself.
Anyway this script was interactive, useful only for experimenters.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
v2: suggest replacing with more specific scripts
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stephen Hemminger Aug. 6, 2020, 4:23 p.m. UTC | #1 
On Thu,  6 Aug 2020 16:51:50 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> Environment configuration is the responsibility of distributions
> or upper-level frameworks.
> DPDK focus on documenting the requirements and some recommendations.
> If some specific parts are complex, they can deserve some scripts.
> 
> Maintaining a good adaptative deployment setup is a project by itself.
> Anyway this script was interactive, useful only for experimenters.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2: suggest replacing with more specific scripts
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1a07f88172..fb405a09ac 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -232,3 +232,8 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> +  ``make``. Given environments are too much variables for such a simple script,
> +  it will be removed in DPDK 20.11.
> +  Some useful parts may be converted into specific scripts.

Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
Users don't always read the deprecation notices.
Thomas Monjalon Aug. 6, 2020, 4:25 p.m. UTC | #2 
06/08/2020 18:23, Stephen Hemminger:
> On Thu,  6 Aug 2020 16:51:50 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > Environment configuration is the responsibility of distributions
> > or upper-level frameworks.
> > DPDK focus on documenting the requirements and some recommendations.
> > If some specific parts are complex, they can deserve some scripts.
> > 
> > Maintaining a good adaptative deployment setup is a project by itself.
> > Anyway this script was interactive, useful only for experimenters.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > v2: suggest replacing with more specific scripts
> > ---
> > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > +  ``make``. Given environments are too much variables for such a simple script,
> > +  it will be removed in DPDK 20.11.
> > +  Some useful parts may be converted into specific scripts.
> 
> Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> Users don't always read the deprecation notices.

Yes we could do that if this deprecation is accepted (missing an ack).
Stephen Hemminger Aug. 6, 2020, 4:56 p.m. UTC | #3 
On Thu, 06 Aug 2020 18:25:23 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 06/08/2020 18:23, Stephen Hemminger:
> > On Thu,  6 Aug 2020 16:51:50 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >   
> > > Environment configuration is the responsibility of distributions
> > > or upper-level frameworks.
> > > DPDK focus on documenting the requirements and some recommendations.
> > > If some specific parts are complex, they can deserve some scripts.
> > > 
> > > Maintaining a good adaptative deployment setup is a project by itself.
> > > Anyway this script was interactive, useful only for experimenters.
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > ---
> > > v2: suggest replacing with more specific scripts
> > > ---
> > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > +  ``make``. Given environments are too much variables for such a simple script,
> > > +  it will be removed in DPDK 20.11.
> > > +  Some useful parts may be converted into specific scripts.  
> > 
> > Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> > Users don't always read the deprecation notices.  
> 
> Yes we could do that if this deprecation is accepted (missing an ack).
> 
> 

Never liked dpdk-setup.sh anyway

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Thomas Monjalon Aug. 6, 2020, 5:02 p.m. UTC | #4 
06/08/2020 18:56, Stephen Hemminger:
> On Thu, 06 Aug 2020 18:25:23 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 06/08/2020 18:23, Stephen Hemminger:
> > > On Thu,  6 Aug 2020 16:51:50 +0200
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >   
> > > > Environment configuration is the responsibility of distributions
> > > > or upper-level frameworks.
> > > > DPDK focus on documenting the requirements and some recommendations.
> > > > If some specific parts are complex, they can deserve some scripts.
> > > > 
> > > > Maintaining a good adaptative deployment setup is a project by itself.
> > > > Anyway this script was interactive, useful only for experimenters.
> > > > 
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > > ---
> > > > v2: suggest replacing with more specific scripts
> > > > ---
> > > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > > +  ``make``. Given environments are too much variables for such a simple script,
> > > > +  it will be removed in DPDK 20.11.
> > > > +  Some useful parts may be converted into specific scripts.  
> > > 
> > > Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> > > Users don't always read the deprecation notices.  
> > 
> > Yes we could do that if this deprecation is accepted (missing an ack).
> 
> Never liked dpdk-setup.sh anyway

Me too

> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 1a07f88172..fb405a09ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -232,3 +232,8 @@  Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
+  ``make``. Given environments are too much variables for such a simple script,
+  it will be removed in DPDK 20.11.
+  Some useful parts may be converted into specific scripts.