diff mbox series

eal: change debug diagnostic message from udev handler

Message ID 20200814174514.25100-1-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series eal: change debug diagnostic message from udev handler |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger Aug. 14, 2020, 5:45 p.m. UTC 
  The debug message was poorly worded and did not include the
part that would be useful. I.e it never said what was being ignored.
Change it to print the message so that if udev changes format or
other subsystems need to be added then the necessary information
will be in the debug log.

Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
Cc: jia.guo@intel.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/linux/eal_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Guo, Jia Aug. 19, 2020, 3:40 a.m. UTC | #1 
hi, stephen

Agree, it is make sense that the ignore event will sometimes involve the 
information which should not be ignore.

On 8/15/2020 1:45 AM, Stephen Hemminger wrote:
> The debug message was poorly worded and did not include the
> part that would be useful. I.e it never said what was being ignored.
> Change it to print the message so that if udev changes format or
> other subsystems need to be added then the necessary information
> will be in the debug log.
>
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> Cc: jia.guo@intel.com


Should this cc line be removed? After that, please and thanks.

Acked-by: Jeff Guo <jia.guo@intel.com>.


> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   lib/librte_eal/linux/eal_dev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
> index 83c9cd660754..83b6068264cb 100644
> --- a/lib/librte_eal/linux/eal_dev.c
> +++ b/lib/librte_eal/linux/eal_dev.c
> @@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
>   
>   	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
>   	if (ret < 0) {
> -		RTE_LOG(DEBUG, EAL, "It is not an valid event "
> -			"that need to be handle.\n");
> +		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
>   		return;
>   	}
>
David Marchand Sept. 16, 2020, 4:20 p.m. UTC | #2 
On Fri, Aug 14, 2020 at 7:45 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The debug message was poorly worded and did not include the
> part that would be useful. I.e it never said what was being ignored.
> Change it to print the message so that if udev changes format or
> other subsystems need to be added then the necessary information
> will be in the debug log.
>
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jeff Guo <jia.guo@intel.com>

Applied.
diff mbox series

Patch

diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
index 83c9cd660754..83b6068264cb 100644
--- a/lib/librte_eal/linux/eal_dev.c
+++ b/lib/librte_eal/linux/eal_dev.c
@@ -234,8 +234,7 @@  dev_uev_handler(__rte_unused void *param)
 
 	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
 	if (ret < 0) {
-		RTE_LOG(DEBUG, EAL, "It is not an valid event "
-			"that need to be handle.\n");
+		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
 		return;
 	}