diff mbox series

[v1,02/18] net/mlx5: fix Rx queue state update

Message ID	1599128029-2092-3-git-send-email-michaelba@nvidia.com (mailing list archive)
State	Accepted, archived
Delegated to:	Raslan Darawsheh
Headers	From: Michael Baum <michaelba@nvidia.com> To: dev@dpdk.org Cc: Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, stable@dpdk.org Date: Thu, 3 Sep 2020 10:13:33 +0000 Message-Id: <1599128029-2092-3-git-send-email-michaelba@nvidia.com> In-Reply-To: <1599128029-2092-1-git-send-email-michaelba@nvidia.com> References: <1599128029-2092-1-git-send-email-michaelba@nvidia.com> Subject: [dpdk-dev] [PATCH v1 02/18] net/mlx5: fix Rx queue state update Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	mlx5 Rx DevX/Verbs separation \| [v1,00/18] mlx5 Rx DevX/Verbs separation [v1,01/18] net/mlx5: fix Rx hash queue creation error flow [v1,02/18] net/mlx5: fix Rx queue state update [v1,03/18] net/mlx5: fix types differentiation in Rxq create [v1,04/18] net/mlx5: mitigate Rx queue reference counters [v1,05/18] net/mlx5: separate Rx queue object creations [v1,06/18] net/mlx5: separate Rx interrupt handling [v1,07/18] net/mlx5: share Rx control code [v1,08/18] net/mlx5: rearrange the creation of RQ and CQ resources [v1,09/18] net/mlx5: rearrange the creation of WQ and CQ object [v1,10/18] net/mlx5: separate Rx queue object modification [v1,11/18] net/mlx5: share Rx queue object modification [v1,12/18] net/mlx5: separate Rx indirection table object creation [v1,13/18] net/mlx5: separate Rx hash queue creation [v1,14/18] net/mlx5: remove indirection table type field [v1,15/18] net/mlx5: share Rx queue indirection table code [v1,16/18] net/mlx5: share Rx hash queue code [v1,17/18] net/mlx5: separate Rx queue drop [v1,18/18] net/mlx5: share Rx queue drop action code

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Michael Baum Sept. 3, 2020, 10:13 a.m. UTC

  In order to support DevX Rx queue stop and start operations, the state
of the queue should be updated in FW.
The state update PRM command requires to set both the current state and
the new requested state.

The current state and the new requested state fields setting were
wrongly switched.

Switch them back to the correct setting.

Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 drivers/net/mlx5/mlx5_rxq.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index 0d16592..2e6cbd4 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -505,8 +505,8 @@ 
 		struct mlx5_devx_modify_rq_attr rq_attr;
 
 		memset(&rq_attr, 0, sizeof(rq_attr));
-		rq_attr.rq_state = MLX5_RQC_STATE_RST;
-		rq_attr.state = MLX5_RQC_STATE_RDY;
+		rq_attr.rq_state = MLX5_RQC_STATE_RDY;
+		rq_attr.state = MLX5_RQC_STATE_RST;
 		ret = mlx5_devx_cmd_modify_rq(rxq_ctrl->obj->rq, &rq_attr);
 	}
 	if (ret) {
@@ -604,7 +604,7 @@ 
 	rte_cio_wmb();
 	*rxq->cq_db = rte_cpu_to_be_32(rxq->cq_ci);
 	rte_cio_wmb();
-	/* Reset RQ consumer before moving queue ro READY state. */
+	/* Reset RQ consumer before moving queue to READY state. */
 	*rxq->rq_db = rte_cpu_to_be_32(0);
 	rte_cio_wmb();
 	if (rxq_ctrl->obj->type == MLX5_RXQ_OBJ_TYPE_IBV) {
@@ -618,8 +618,8 @@ 
 		struct mlx5_devx_modify_rq_attr rq_attr;
 
 		memset(&rq_attr, 0, sizeof(rq_attr));
-		rq_attr.rq_state = MLX5_RQC_STATE_RDY;
-		rq_attr.state = MLX5_RQC_STATE_RST;
+		rq_attr.rq_state = MLX5_RQC_STATE_RST;
+		rq_attr.state = MLX5_RQC_STATE_RDY;
 		ret = mlx5_devx_cmd_modify_rq(rxq_ctrl->obj->rq, &rq_attr);
 	}
 	if (ret) {