diff mbox series

[4/9] net/i40e/base: fix missing function header arguments

Message ID	20200905024938.14609-5-guinanx.sun@intel.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: LaD4RBNOM3Fg1/JAbiDClTGVwVyG5J5xVD+wYpgaIdetgo5SCGEiTT898L/Cz7H7QQjqR/SX1+ Uf/BzJEhE4Ww== IronPort-SDR: z7yjn/NWNm0/dH4RFmg0KZW4YXGVjc2JOlrgHkO1k1Vmzq9hwUj9XCoUEWy/Uoa9im+3a75d0M /YCfAPo9ybiA== From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Beilei Xing <beilei.xing@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Qiming Yang <qiming.yang@intel.com>, Guinan Sun <guinanx.sun@intel.com>, stable@dpdk.org, Jesse Brandeburg <jesse.brandeburg@intel.com> Date: Sat, 5 Sep 2020 02:49:33 +0000 Message-Id: <20200905024938.14609-5-guinanx.sun@intel.com> In-Reply-To: <20200905024938.14609-1-guinanx.sun@intel.com> References: <20200905024938.14609-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH 4/9] net/i40e/base: fix missing function header arguments Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update i40e base code \| [0/9] update i40e base code [1/9] net/i40e/base: add VLAN field for input set [2/9] net/i40e/base: update FW API version [3/9] net/i40e/base: enable pipe monitor thresholds [4/9] net/i40e/base: fix missing function header arguments [5/9] net/i40e/base: add support for minimum rollback revision [6/9] net/i40e/base: fix Rx only for unicast promisc on VLAN [7/9] net/i40e/base: add EEE LPI status check for X722 adapters [8/9] net/i40e/base: fix PHY config param when enabling EEE [9/9] net/i40e/base: update version

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Guinan Sun Sept. 5, 2020, 2:49 a.m. UTC

  Fix them by adding the argument descriptions.

Fixes: 0d9d27bb8684 ("i40e/base: prepare local LLDP MIB in TLV")
Cc: stable@dpdk.org

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/i40e/base/i40e_dcb.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Qiming Yang Sept. 8, 2020, 8:03 a.m. UTC | #1

> -----Original Message-----
> From: Sun, GuinanX <guinanx.sun@intel.com>
> Sent: Saturday, September 5, 2020 10:50
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Yang, Qiming <qiming.yang@intel.com>; Sun, GuinanX
> <guinanx.sun@intel.com>; stable@dpdk.org; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>
> Subject: [PATCH 4/9] net/i40e/base: fix missing function header arguments
> 
> Fix them by adding the argument descriptions.
> 
> Fixes: 0d9d27bb8684 ("i40e/base: prepare local LLDP MIB in TLV")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
>  drivers/net/i40e/base/i40e_dcb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/base/i40e_dcb.c
> b/drivers/net/i40e/base/i40e_dcb.c
> index a07c61e67..388af3d64 100644
> --- a/drivers/net/i40e/base/i40e_dcb.c
> +++ b/drivers/net/i40e/base/i40e_dcb.c
> @@ -1267,7 +1267,8 @@ enum i40e_status_code
> i40e_set_dcb_config(struct i40e_hw *hw)
> 
>  /**
>   * i40e_dcb_config_to_lldp - Convert Dcbconfig to MIB format
> - * @hw: pointer to the hw struct
> + * @lldpmib: pointer to mib to be output
> + * @miblen: pointer to u16 for length of lldpmib

Only parameter description change? No function change?

>   * @dcbcfg: store for LLDPDU data
>   *
>   * send DCB configuration to FW
> --
> 2.17.1

diff mbox series

Patch

diff --git a/drivers/net/i40e/base/i40e_dcb.c b/drivers/net/i40e/base/i40e_dcb.c
index a07c61e67..388af3d64 100644
--- a/drivers/net/i40e/base/i40e_dcb.c
+++ b/drivers/net/i40e/base/i40e_dcb.c
@@ -1267,7 +1267,8 @@  enum i40e_status_code i40e_set_dcb_config(struct i40e_hw *hw)
 
 /**
  * i40e_dcb_config_to_lldp - Convert Dcbconfig to MIB format
- * @hw: pointer to the hw struct
+ * @lldpmib: pointer to mib to be output
+ * @miblen: pointer to u16 for length of lldpmib
  * @dcbcfg: store for LLDPDU data
  *
  * send DCB configuration to FW