net/ice/base: fix wrong outer ipv6 ptype table
Checks
Commit Message
ptype 264, 265, 266, 267, 275 is should not be set
in ice_ptypes_ipv6_ofos_all.
Fixes: 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
drivers/net/ice/base/ice_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Sunday, September 6, 2020 9:02 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table
>
> ptype 264, 265, 266, 267, 275 is should not be set in ice_ptypes_ipv6_ofos_all.
>
A tiny comment, "is" should be deleted, right? And I think ptype name is more readable than number when interpret the reason, you choose.
After that patch is ok.
Acked-by: Jeff Guo <jia.guo@intel.com>
> Fixes: 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/base/ice_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/base/ice_flow.c
> b/drivers/net/ice/base/ice_flow.c index 6035bdfcf..552e58f9b 100644
> --- a/drivers/net/ice/base/ice_flow.c
> +++ b/drivers/net/ice/base/ice_flow.c
> @@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = { static
> const u32 ice_ptypes_ipv6_ofos_all[] = {
> 0x00000000, 0x00000000, 0x77000000, 0x10002000,
> 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
> - 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206,
> + 0x00000000, 0x03F00000, 0x7C1F0000, 0x00000206,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> --
> 2.13.6
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Tuesday, September 8, 2020 11:59 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> > Sent: Sunday, September 6, 2020 9:02 PM
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype
> > table
> >
> > ptype 264, 265, 266, 267, 275 is should not be set in
> ice_ptypes_ipv6_ofos_all.
> >
>
> A tiny comment, "is" should be deleted, right?
yes
> And I think ptype name is more
> readable than number when interpret the reason, you choose.
> After that patch is ok.
These ptypes are reserved, they have no name.
>
> Acked-by: Jeff Guo <jia.guo@intel.com>
Applied to dpdk-next-net-intel after correct the commit log.
Thanks
Qi
@@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = {
static const u32 ice_ptypes_ipv6_ofos_all[] = {
0x00000000, 0x00000000, 0x77000000, 0x10002000,
0x00000000, 0x000002AA, 0x00000000, 0x00000000,
- 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206,
+ 0x00000000, 0x03F00000, 0x7C1F0000, 0x00000206,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,
0x00000000, 0x00000000, 0x00000000, 0x00000000,