[v11,19/24] examples/multi_proc*: new link status print format
Checks
Commit Message
Add usage of rte_eth_link_to_str function to example
applications
Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
---
.../client_server_mp/mp_server/init.c | 15 ++++++---------
examples/multi_process/symmetric_mp/main.c | 13 +++++--------
2 files changed, 11 insertions(+), 17 deletions(-)
Comments
On 9/15/2020 8:07 PM, Ivan Dyukov wrote:
> Add usage of rte_eth_link_to_str function to example
> applications
>
> Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
> ---
> .../client_server_mp/mp_server/init.c | 15 ++++++---------
> examples/multi_process/symmetric_mp/main.c | 13 +++++--------
> 2 files changed, 11 insertions(+), 17 deletions(-)
>
> diff --git a/examples/multi_process/client_server_mp/mp_server/init.c b/examples/multi_process/client_server_mp/mp_server/init.c
> index c2ec07ac6..a7f5207c3 100644
> --- a/examples/multi_process/client_server_mp/mp_server/init.c
> +++ b/examples/multi_process/client_server_mp/mp_server/init.c
> @@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> uint8_t count, all_ports_up, print_flag = 0;
> struct rte_eth_link link;
> int ret;
> + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
>
> printf("\nChecking link status");
> fflush(stdout);
> @@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> }
> /* print link status if flag set */
> if (print_flag == 1) {
> - if (link.link_status)
> - printf("Port %d Link Up - speed %u "
> - "Mbps - %s\n", ports->id[portid],
> - (unsigned)link.link_speed,
> - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
> - ("full-duplex") : ("half-duplex"));
> - else
> - printf("Port %d Link Down\n",
> - (uint8_t)ports->id[portid]);
> + rte_eth_link_to_str(link_status_text,
> + sizeof(link_status_text), &link);
> + printf("Port %d %s\n",
> + (uint8_t)ports->id[portid],
> + link_status_text);
This is not related to your patch, but port is 16bits, it shouldn't be
cast to 'uint8_t'.
> continue;
> }
> /* clear all_ports_up flag if any link down */
> diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
> index 9a16e198c..33643d354 100644
> --- a/examples/multi_process/symmetric_mp/main.c
> +++ b/examples/multi_process/symmetric_mp/main.c
> @@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> uint8_t count, all_ports_up, print_flag = 0;
> struct rte_eth_link link;
> int ret;
> + char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
>
> printf("\nChecking link status");
> fflush(stdout);
> @@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
> }
> /* print link status if flag set */
> if (print_flag == 1) {
> - if (link.link_status)
> - printf(
> - "Port%d Link Up. Speed %u Mbps - %s\n",
> - portid, link.link_speed,
> - (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
> - ("full-duplex") : ("half-duplex"));
> - else
> - printf("Port %d Link Down\n", portid);
> + rte_eth_link_to_str(link_status_text,
> + sizeof(link_status_text), &link);
> + printf("Port %d %s\n", portid,
> + link_status_text);
> continue;
> }
> /* clear all_ports_up flag if any link down */
>
@@ -185,6 +185,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
uint8_t count, all_ports_up, print_flag = 0;
struct rte_eth_link link;
int ret;
+ char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
printf("\nChecking link status");
fflush(stdout);
@@ -204,15 +205,11 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
}
/* print link status if flag set */
if (print_flag == 1) {
- if (link.link_status)
- printf("Port %d Link Up - speed %u "
- "Mbps - %s\n", ports->id[portid],
- (unsigned)link.link_speed,
- (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
- ("full-duplex") : ("half-duplex"));
- else
- printf("Port %d Link Down\n",
- (uint8_t)ports->id[portid]);
+ rte_eth_link_to_str(link_status_text,
+ sizeof(link_status_text), &link);
+ printf("Port %d %s\n",
+ (uint8_t)ports->id[portid],
+ link_status_text);
continue;
}
/* clear all_ports_up flag if any link down */
@@ -365,6 +365,7 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
uint8_t count, all_ports_up, print_flag = 0;
struct rte_eth_link link;
int ret;
+ char link_status_text[RTE_ETH_LINK_MAX_STR_LEN];
printf("\nChecking link status");
fflush(stdout);
@@ -384,14 +385,10 @@ check_all_ports_link_status(uint16_t port_num, uint32_t port_mask)
}
/* print link status if flag set */
if (print_flag == 1) {
- if (link.link_status)
- printf(
- "Port%d Link Up. Speed %u Mbps - %s\n",
- portid, link.link_speed,
- (link.link_duplex == ETH_LINK_FULL_DUPLEX) ?
- ("full-duplex") : ("half-duplex"));
- else
- printf("Port %d Link Down\n", portid);
+ rte_eth_link_to_str(link_status_text,
+ sizeof(link_status_text), &link);
+ printf("Port %d %s\n", portid,
+ link_status_text);
continue;
}
/* clear all_ports_up flag if any link down */