[3/3] doc: fix vector mode info for bnxt
Checks
Commit Message
Vector mode is disabled when jumbo frames are enabled.
This usage guide was reporting it incorrectly.
Fixes: 1adaf0e0f2ee ("doc: update bnxt guide")
Cc:stable@dpdk.org
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
doc/guides/nics/bnxt.rst | 1 -
1 file changed, 1 deletion(-)
Comments
On Tue, Sep 29, 2020 at 5:01 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Vector mode is disabled when jumbo frames are enabled.
> This usage guide was reporting it incorrectly.
>
> Fixes: 1adaf0e0f2ee ("doc: update bnxt guide")
> Cc:stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> doc/guides/nics/bnxt.rst | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst
> index 129a16cfc..48ec6156d 100644
> --- a/doc/guides/nics/bnxt.rst
> +++ b/doc/guides/nics/bnxt.rst
> @@ -836,7 +836,6 @@ This improved performance comes from several optimizations:
>
> DEV_RX_OFFLOAD_VLAN_STRIP
> DEV_RX_OFFLOAD_KEEP_CRC
> - DEV_RX_OFFLOAD_JUMBO_FRAME
> DEV_RX_OFFLOAD_IPV4_CKSUM
> DEV_RX_OFFLOAD_UDP_CKSUM
> DEV_RX_OFFLOAD_TCP_CKSUM
> --
> 2.21.1 (Apple Git-122.3)
>
NAK - receive vector mode *is* allowed when jumbo is enabled, as
long as the MTU is not large enough to require scattered RX (which
also depends on the mbuf size).
Lance
On Wed, Sep 30, 2020 at 10:28 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Tue, Sep 29, 2020 at 5:01 PM Ajit Khaparde
> <ajit.khaparde@broadcom.com> wrote:
> >
> > Vector mode is disabled when jumbo frames are enabled.
> > This usage guide was reporting it incorrectly.
> >
> > Fixes: 1adaf0e0f2ee ("doc: update bnxt guide")
> > Cc:stable@dpdk.org
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> > doc/guides/nics/bnxt.rst | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst
> > index 129a16cfc..48ec6156d 100644
> > --- a/doc/guides/nics/bnxt.rst
> > +++ b/doc/guides/nics/bnxt.rst
> > @@ -836,7 +836,6 @@ This improved performance comes from several optimizations:
> >
> > DEV_RX_OFFLOAD_VLAN_STRIP
> > DEV_RX_OFFLOAD_KEEP_CRC
> > - DEV_RX_OFFLOAD_JUMBO_FRAME
> > DEV_RX_OFFLOAD_IPV4_CKSUM
> > DEV_RX_OFFLOAD_UDP_CKSUM
> > DEV_RX_OFFLOAD_TCP_CKSUM
> > --
> > 2.21.1 (Apple Git-122.3)
> >
>
> NAK - receive vector mode *is* allowed when jumbo is enabled, as
> long as the MTU is not large enough to require scattered RX (which
> also depends on the mbuf size).
Ok. Fair enough. Let me drop this patch.
>
> Lance
@@ -836,7 +836,6 @@ This improved performance comes from several optimizations:
DEV_RX_OFFLOAD_VLAN_STRIP
DEV_RX_OFFLOAD_KEEP_CRC
- DEV_RX_OFFLOAD_JUMBO_FRAME
DEV_RX_OFFLOAD_IPV4_CKSUM
DEV_RX_OFFLOAD_UDP_CKSUM
DEV_RX_OFFLOAD_TCP_CKSUM