[v2,1/9] event/dpaa2: remove dead code

Message ID 20201028122013.31104-2-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series remove mbuf seqn |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand Oct. 28, 2020, 12:20 p.m. UTC
  This code has never been used since introduction.

Fixes: 653242c3375a ("event/dpaa2: add self test")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)
  

Comments

Nipun Gupta Oct. 31, 2020, 6:28 p.m. UTC | #1
Acked-by: Nipun Gupta <nipun.gupta@nxp.com>

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, October 28, 2020 5:50 PM
> To: dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta
> <nipun.gupta@nxp.com>
> Subject: [PATCH v2 1/9] event/dpaa2: remove dead code
> 
> This code has never been used since introduction.
> 
> Fixes: 653242c3375a ("event/dpaa2: add self test")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/event/dpaa2/dpaa2_eventdev_selftest.c | 13 +------------
>  1 file changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
> b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
> index b1f3891484..5447db8a8a 100644
> --- a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
> +++ b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
> @@ -47,17 +47,6 @@ struct event_attr {
>  	uint8_t seq;
>  };
> 
> -static uint32_t seqn_list_index;
> -static int seqn_list[NUM_PACKETS];
> -
> -static void
> -seqn_list_init(void)
> -{
> -	RTE_BUILD_BUG_ON(NUM_PACKETS < MAX_EVENTS);
> -	memset(seqn_list, 0, sizeof(seqn_list));
> -	seqn_list_index = 0;
> -}
> -
>  struct test_core_param {
>  	rte_atomic32_t *total_events;
>  	uint64_t dequeue_tmo_ticks;
> @@ -516,7 +505,7 @@ launch_workers_and_wait(int (*main_worker)(void *),
>  		return 0;
> 
>  	rte_atomic32_set(&atomic_total_events, total_events);
> -	seqn_list_init();
> +	RTE_BUILD_BUG_ON(NUM_PACKETS < MAX_EVENTS);
> 
>  	param = malloc(sizeof(struct test_core_param) * nb_workers);
>  	if (!param)
> --
> 2.23.0
  

Patch

diff --git a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
index b1f3891484..5447db8a8a 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
+++ b/drivers/event/dpaa2/dpaa2_eventdev_selftest.c
@@ -47,17 +47,6 @@  struct event_attr {
 	uint8_t seq;
 };
 
-static uint32_t seqn_list_index;
-static int seqn_list[NUM_PACKETS];
-
-static void
-seqn_list_init(void)
-{
-	RTE_BUILD_BUG_ON(NUM_PACKETS < MAX_EVENTS);
-	memset(seqn_list, 0, sizeof(seqn_list));
-	seqn_list_index = 0;
-}
-
 struct test_core_param {
 	rte_atomic32_t *total_events;
 	uint64_t dequeue_tmo_ticks;
@@ -516,7 +505,7 @@  launch_workers_and_wait(int (*main_worker)(void *),
 		return 0;
 
 	rte_atomic32_set(&atomic_total_events, total_events);
-	seqn_list_init();
+	RTE_BUILD_BUG_ON(NUM_PACKETS < MAX_EVENTS);
 
 	param = malloc(sizeof(struct test_core_param) * nb_workers);
 	if (!param)