diff mbox series

[7/8] ionic: warn if RTE tries to enable loopback mode

Message ID 20201102183527.69209-8-aboyer@pensando.io (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series net/ionic: minor updates and documentation |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Andrew Boyer Nov. 2, 2020, 6:35 p.m. UTC 
  The ionic FW does not support loopback mode at this time.

Signed-off-by: Andrew Boyer <aboyer@pensando.io>
---
 drivers/net/ionic/ionic_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ferruh Yigit Nov. 3, 2020, 12:52 p.m. UTC | #1 
On 11/2/2020 6:35 PM, Andrew Boyer wrote:
> The ionic FW does not support loopback mode at this time.
> 

"RTE tries to enable"? what about,
net/ionic: warn if loopback mode is requested

> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
> ---
>   drivers/net/ionic/ionic_ethdev.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c
> index 600333e20..ff5c2e51a 100644
> --- a/drivers/net/ionic/ionic_ethdev.c
> +++ b/drivers/net/ionic/ionic_ethdev.c
> @@ -919,6 +919,9 @@ ionic_dev_start(struct rte_eth_dev *eth_dev)
>   		return -EINVAL;
>   	}
>   
> +	if (dev_conf->lpbk_mode)
> +		IONIC_PRINT(WARNING, "Loopback mode not supported");
> +
>   	err = ionic_lif_start(lif);
>   	if (err) {
>   		IONIC_PRINT(ERR, "Cannot start LIF: %d", err);
>
diff mbox series

Patch

diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c
index 600333e20..ff5c2e51a 100644
--- a/drivers/net/ionic/ionic_ethdev.c
+++ b/drivers/net/ionic/ionic_ethdev.c
@@ -919,6 +919,9 @@  ionic_dev_start(struct rte_eth_dev *eth_dev)
 		return -EINVAL;
 	}
 
+	if (dev_conf->lpbk_mode)
+		IONIC_PRINT(WARNING, "Loopback mode not supported");
+
 	err = ionic_lif_start(lif);
 	if (err) {
 		IONIC_PRINT(ERR, "Cannot start LIF: %d", err);