[2/2] doc: update build guide for armv8 crypto PMD

Message ID 20201105153316.27918-2-dharmik.thakkar@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] crypto/armv8: update meson build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Dharmik Thakkar Nov. 5, 2020, 3:33 p.m. UTC
  Remove build steps about using meson option armv8_crypto_dir.

Add build steps about using pkg-config.

Suggested-by: Thomas Monjalon <thomas@monjalon.net>
Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 doc/guides/cryptodevs/armv8.rst | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
  

Comments

Ruifeng Wang Nov. 6, 2020, 1:39 a.m. UTC | #1
> -----Original Message-----
> From: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Sent: Thursday, November 5, 2020 11:33 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Dharmik Thakkar
> <Dharmik.Thakkar@arm.com>
> Subject: [PATCH 2/2] doc: update build guide for armv8 crypto PMD
> 
> Remove build steps about using meson option armv8_crypto_dir.
> 
> Add build steps about using pkg-config.
> 
> Suggested-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>  doc/guides/cryptodevs/armv8.rst | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/cryptodevs/armv8.rst
> b/doc/guides/cryptodevs/armv8.rst index f0f30fe0003a..8963f66a206c
> 100644
> --- a/doc/guides/cryptodevs/armv8.rst
> +++ b/doc/guides/cryptodevs/armv8.rst
> @@ -37,11 +37,17 @@ To build DPDK with this virtual crypto PMD, the user is
> required to:
> 
>     make
> 
> -* Build DPDK with meson option ``-
> Darmv8_crypto_dir=<path_to_AArch64cryptolib>``:
> +* Add path to `libAArch64crypto.pc` in `PKG_CONFIG_PATH` environment
> variable:
> 
>  .. code-block:: console
> 
> -   meson -Darmv8_crypto_dir=<path_to_AArch64cryptolib> build
> +   export
> +
> PKG_CONFIG_PATH=<path_to_AArch64cryptolib>/pkgconfig/:$PKG_CONFI
> G_PATH
> +
> +* Build DPDK:
> +
> +.. code-block:: console
> +
> +   meson build
>     ninja -C build
> 
>  The corresponding device can be created only if the following features
> --
> 2.17.1

Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
  

Patch

diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst
index f0f30fe0003a..8963f66a206c 100644
--- a/doc/guides/cryptodevs/armv8.rst
+++ b/doc/guides/cryptodevs/armv8.rst
@@ -37,11 +37,17 @@  To build DPDK with this virtual crypto PMD, the user is required to:
 
    make
 
-* Build DPDK with meson option ``-Darmv8_crypto_dir=<path_to_AArch64cryptolib>``:
+* Add path to `libAArch64crypto.pc` in `PKG_CONFIG_PATH` environment variable:
 
 .. code-block:: console
 
-   meson -Darmv8_crypto_dir=<path_to_AArch64cryptolib> build
+   export PKG_CONFIG_PATH=<path_to_AArch64cryptolib>/pkgconfig/:$PKG_CONFIG_PATH
+
+* Build DPDK:
+
+.. code-block:: console
+
+   meson build
    ninja -C build
 
 The corresponding device can be created only if the following features