usertools/cpu_layout: fix code to be pep8 style compliant
Checks
Commit Message
The pycodestyle tool flagged the following issues, which are now fixed.
$ pycodestyle cpu_layout.py
cpu_layout.py:18:5: E722 do not use bare 'except'
cpu_layout.py:62:14: E231 missing whitespace after ','
Fixes: deb87e6777c0 ("usertools: use sysfs for CPU layout")
Fixes: c9208f1dc967 ("usertools: fix CPU layout with python 3")
Cc: andriy.berestovskyy@caviumnetworks.com
Cc: thomas@monjalon.net
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
usertools/cpu_layout.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Comments
06/11/2020 13:40, Ciara Power:
> The pycodestyle tool flagged the following issues, which are now fixed.
>
> $ pycodestyle cpu_layout.py
> cpu_layout.py:18:5: E722 do not use bare 'except'
> cpu_layout.py:62:14: E231 missing whitespace after ','
>
> Fixes: deb87e6777c0 ("usertools: use sysfs for CPU layout")
> Fixes: c9208f1dc967 ("usertools: fix CPU layout with python 3")
> Cc: andriy.berestovskyy@caviumnetworks.com
> Cc: thomas@monjalon.net
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Applied, thanks
@@ -15,8 +15,6 @@
fd = open("{}/cpu{}/topology/core_id".format(base_path, cpu))
except IOError:
continue
- except:
- break
core = int(fd.read())
fd.close()
fd = open("{}/cpu{}/topology/physical_package_id".format(base_path, cpu))
@@ -59,7 +57,7 @@
for c in cores:
output = "Core %s" % str(c).ljust(max_core_id_len)
for s in sockets:
- if (s,c) in core_map:
+ if (s, c) in core_map:
output += " " + str(core_map[(s, c)]).ljust(max_core_map_len)
else:
output += " " * (max_core_map_len + 1)