diff mbox series

[v2,7/7] net/bnxt: fix redundant return

Message ID 20201118114525.99053-8-ferruh.yigit@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series cppcheck |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-testing warning Testing issues
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Ferruh Yigit Nov. 18, 2020, 11:45 a.m. UTC 
  Removing useless 'return' statement.

Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: peter.spreadborough@broadcom.com
---
 drivers/net/bnxt/tf_core/tf_em_common.c | 1 -
 1 file changed, 1 deletion(-)

Comments

David Marchand Nov. 18, 2020, 2:42 p.m. UTC | #1 
On Wed, Nov 18, 2020 at 12:48 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Removing useless 'return' statement.
>
> Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: peter.spreadborough@broadcom.com
> ---
>  drivers/net/bnxt/tf_core/tf_em_common.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c
> index ad92cbdc75..c96c21c2e9 100644
> --- a/drivers/net/bnxt/tf_core/tf_em_common.c
> +++ b/drivers/net/bnxt/tf_core/tf_em_common.c
> @@ -307,7 +307,6 @@ tf_em_page_tbl_pgcnt(uint32_t num_pages,
>  {
>         return roundup(num_pages, MAX_PAGE_PTRS(page_size)) /
>                        MAX_PAGE_PTRS(page_size);
> -       return 0;
>  }
>
>  /**

Reviewed-by: David Marchand <david.marchand@redhat.com>
Ajit Khaparde Nov. 18, 2020, 4:12 p.m. UTC | #2 
On Wed, Nov 18, 2020 at 6:43 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Wed, Nov 18, 2020 at 12:48 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > Removing useless 'return' statement.
> >
> > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Cc: peter.spreadborough@broadcom.com
> > ---
> >  drivers/net/bnxt/tf_core/tf_em_common.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c
> > index ad92cbdc75..c96c21c2e9 100644
> > --- a/drivers/net/bnxt/tf_core/tf_em_common.c
> > +++ b/drivers/net/bnxt/tf_core/tf_em_common.c
> > @@ -307,7 +307,6 @@ tf_em_page_tbl_pgcnt(uint32_t num_pages,
> >  {
> >         return roundup(num_pages, MAX_PAGE_PTRS(page_size)) /
> >                        MAX_PAGE_PTRS(page_size);
> > -       return 0;
> >  }
> >
> >  /**
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

>
>
> --
> David Marchand
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/tf_core/tf_em_common.c b/drivers/net/bnxt/tf_core/tf_em_common.c
index ad92cbdc75..c96c21c2e9 100644
--- a/drivers/net/bnxt/tf_core/tf_em_common.c
+++ b/drivers/net/bnxt/tf_core/tf_em_common.c
@@ -307,7 +307,6 @@  tf_em_page_tbl_pgcnt(uint32_t num_pages,
 {
 	return roundup(num_pages, MAX_PAGE_PTRS(page_size)) /
 		       MAX_PAGE_PTRS(page_size);
-	return 0;
 }
 
 /**