doc: update features for hns3
Checks
Commit Message
Since the hns3 NIC hardware features are not counted
and it is supported in fact. Besides, the flow director
is not supported and need to delete it.
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
doc/guides/nics/features/hns3.ini | 8 ++++++++
doc/guides/nics/hns3.rst | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
Comments
On 11/23/2020 2:32 PM, Lijun Ou wrote:
> Since the hns3 NIC hardware features are not counted
> and it is supported in fact. Besides, the flow director
> is not supported and need to delete it.
>
Hi Lijun,
Normally these should be updated when the feature is added but it seems we have
missed them.
Can you please add the commits that introduces the features as "Fixes: " line,
to have them as reference?
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> doc/guides/nics/features/hns3.ini | 8 ++++++++
> doc/guides/nics/hns3.rst | 3 ++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
> index fc61dde..f897a14 100644
> --- a/doc/guides/nics/features/hns3.ini
> +++ b/doc/guides/nics/features/hns3.ini
> @@ -7,8 +7,12 @@
> Link status = Y
> Rx interrupt = Y
> Queue start/stop = Y
> +Runtime Rx queue setup = Y
> +Runtime Tx queue setup = Y
> +Burst mode info = Y
> MTU update = Y
> Jumbo frame = Y
> +Fast mbuf free = Y
> Scattered Rx = Y
> TSO = Y
> LRO = Y
> @@ -20,19 +24,23 @@ RSS hash = Y
> RSS key update = Y
> RSS reta update = Y
> DCB = Y
> +SR-IOV = Y
> VLAN filter = Y
> Flow control = Y
> Flow API = Y
> CRC offload = Y
> VLAN offload = Y
> +QinQ offload = P
Is "QinQ offload" supported? I don't see the driver setting neither
'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags.
Can you please describe in the commit log why it is supported partially (P)?
在 2020/11/24 0:41, Ferruh Yigit 写道:
> On 11/23/2020 2:32 PM, Lijun Ou wrote:
>> Since the hns3 NIC hardware features are not counted
>> and it is supported in fact. Besides, the flow director
>> is not supported and need to delete it.
>>
>
> Hi Lijun,
>
> Normally these should be updated when the feature is added but it seems
> we have missed them.
>
Yes. Maybe it is ignoranted. As a result,it needs to add.
> Can you please add the commits that introduces the features as "Fixes: "
> line, to have them as reference?
>
Yes, I can. I will add it in next patch.
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>> doc/guides/nics/features/hns3.ini | 8 ++++++++
>> doc/guides/nics/hns3.rst | 3 ++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/nics/features/hns3.ini
>> b/doc/guides/nics/features/hns3.ini
>> index fc61dde..f897a14 100644
>> --- a/doc/guides/nics/features/hns3.ini
>> +++ b/doc/guides/nics/features/hns3.ini
>> @@ -7,8 +7,12 @@
>> Link status = Y
>> Rx interrupt = Y
>> Queue start/stop = Y
>> +Runtime Rx queue setup = Y
>> +Runtime Tx queue setup = Y
>> +Burst mode info = Y
>> MTU update = Y
>> Jumbo frame = Y
>> +Fast mbuf free = Y
>> Scattered Rx = Y
>> TSO = Y
>> LRO = Y
>> @@ -20,19 +24,23 @@ RSS hash = Y
>> RSS key update = Y
>> RSS reta update = Y
>> DCB = Y
>> +SR-IOV = Y
>> VLAN filter = Y
>> Flow control = Y
>> Flow API = Y
>> CRC offload = Y
>> VLAN offload = Y
>> +QinQ offload = P
>
> Is "QinQ offload" supported? I don't see the driver setting neither
> 'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags.
> Can you please describe in the commit log why it is supported partially
> (P)?
> .
Sorry. hns3 support to QinQ insert in the Tx direction and the QinQ
stripped in Rx direction is not supported. QinQ offloading is considered
as the former. I will fix it.
>
@@ -7,8 +7,12 @@
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
+Runtime Rx queue setup = Y
+Runtime Tx queue setup = Y
+Burst mode info = Y
MTU update = Y
Jumbo frame = Y
+Fast mbuf free = Y
Scattered Rx = Y
TSO = Y
LRO = Y
@@ -20,19 +24,23 @@ RSS hash = Y
RSS key update = Y
RSS reta update = Y
DCB = Y
+SR-IOV = Y
VLAN filter = Y
Flow control = Y
Flow API = Y
CRC offload = Y
VLAN offload = Y
+QinQ offload = P
L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
Inner L4 checksum = Y
+Packet type parsing = Y
Basic stats = Y
Extended stats = Y
Stats per queue = Y
FW version = Y
+Registers dump = Y
Multiprocess aware = Y
Linux UIO = Y
Linux VFIO = Y
@@ -29,13 +29,14 @@ Features of the HNS3 PMD are:
- QinQ inserting
- DCB
- Scattered and gather for TX and RX
-- Flow director
+- Vector Poll mode driver
- Dump register
- SR-IOV VF
- Multi-process
- MAC/VLAN filter
- MTU update
- NUMA support
+- Generic flow API
Prerequisites
-------------