Message ID | 20201209031628.29572-10-stevex.yang@intel.com (mailing list archive) |
---|---|
State | Superseded, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86388A09E9; Wed, 9 Dec 2020 04:22:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51968C98C; Wed, 9 Dec 2020 04:21:02 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6E6F6C99C for <dev@dpdk.org>; Wed, 9 Dec 2020 04:21:00 +0100 (CET) IronPort-SDR: TG7z7m1ol+AtnSLWtQ7ZuB/Lb4BfiGFQ/LJDveEF3kZYNxARZEYDMlsqaBcFXXYDFNUZY3lJ3T KHrXsLueXO9Q== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="192310565" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="192310565" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 19:20:58 -0800 IronPort-SDR: hX73hLooxmSWgYXKGdybBVyYtLl5yi83WQaJgfuFOQR+JAi1geMH4oG+FryTnNC4d+wFnPJFzc p6n+IBnuDLYw== X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="363949042" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 19:20:47 -0800 From: Steve Yang <stevex.yang@intel.com> To: dev@dpdk.org Cc: hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com, haiyue.wang@intel.com, xavier.huwei@huawei.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com, rosen.xu@intel.com, hkalra@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com, shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com, wei.dai@intel.com, fengchunsong@huawei.com, lihuisong@huawei.com, ferruh.yigit@intel.com, chenhao164@huawei.com, helin.zhang@intel.com, konstantin.ananyev@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com, ting.xu@intel.com, xiaoyun.li@intel.com, wenzhuo.lu@intel.com, andy.pei@intel.com, dan.wei@intel.com, skori@marvell.com, vattunuru@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com, ivan.malov@oktetlabs.ru, zyta.szpak@semihalf.com, slawomir.rosek@semihalf.com, rad@semihalf.com, Steve Yang <stevex.yang@intel.com> Date: Wed, 9 Dec 2020 03:16:25 +0000 Message-Id: <20201209031628.29572-10-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com> References: <20201209031628.29572-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag condition for mtu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
fix rx packets dropped issue
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Steve Yang
Dec. 9, 2020, 3:16 a.m. UTC
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but
the Ether overhead is larger than 18 when it supports dual VLAN tags.
That will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.
This fix will change the boundary condition with 'RTE_ETHER_MTU'.
Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
>-----Original Message----- >From: Steve Yang <stevex.yang@intel.com> >Sent: Wednesday, December 9, 2020 8:46 AM >To: dev@dpdk.org >Cc: hemant.agrawal@nxp.com; sachin.saxena@oss.nxp.com; >jia.guo@intel.com; haiyue.wang@intel.com; xavier.huwei@huawei.com; >humin29@huawei.com; yisen.zhuang@huawei.com; oulijun@huawei.com; >beilei.xing@intel.com; jingjing.wu@intel.com; qiming.yang@intel.com; >qi.z.zhang@intel.com; rosen.xu@intel.com; Harman Kalra ><hkalra@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; >Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar >Kokkilagadda <kirankumark@marvell.com>; Rasesh Mody ><rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; >andrew.rybchenko@oktetlabs.ru; Maciej Czekaj [C] <mczekaj@marvell.com>; >wei.dai@intel.com; fengchunsong@huawei.com; lihuisong@huawei.com; >ferruh.yigit@intel.com; chenhao164@huawei.com; helin.zhang@intel.com; >konstantin.ananyev@intel.com; yanglong.wu@intel.com; >xiaolong.ye@intel.com; ting.xu@intel.com; xiaoyun.li@intel.com; >wenzhuo.lu@intel.com; andy.pei@intel.com; dan.wei@intel.com; Sunil >Kumar Kori <skori@marvell.com>; Vamsi Krishna Attunuru ><vattunuru@marvell.com>; sony.chacko@qlogic.com; >bruce.richardson@intel.com; ivan.malov@oktetlabs.ru; >zyta.szpak@semihalf.com; slawomir.rosek@semihalf.com; >rad@semihalf.com; Steve Yang <stevex.yang@intel.com> >Subject: [EXT] [PATCH v1 09/12] net/octeontx2: fix the jumbo frame flag >condition for mtu > >External Email > >---------------------------------------------------------------------- >The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but >the Ether overhead is larger than 18 when it supports dual VLAN tags. >That will cause the jumbo flag rx offload is wrong when MTU size is >'RTE_ETHER_MTU'. > >This fix will change the boundary condition with 'RTE_ETHER_MTU'. > >Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > >Signed-off-by: Steve Yang <stevex.yang@intel.com> >--- > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c >b/drivers/net/octeontx2/otx2_ethdev_ops.c >index b36d37b9f7..170b8fbd91 100644 >--- a/drivers/net/octeontx2/otx2_ethdev_ops.c >+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c >@@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t >mtu) > if (rc) > return rc; > >- if (frame_size > RTE_ETHER_MAX_LEN) >+ if (mtu > RTE_ETHER_MTU) > dev->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; > else > dev->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; >-- >2.17.1 Acked-by: Sunil Kumar Kori <skori@mavell.com>
diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c b/drivers/net/octeontx2/otx2_ethdev_ops.c index b36d37b9f7..170b8fbd91 100644 --- a/drivers/net/octeontx2/otx2_ethdev_ops.c +++ b/drivers/net/octeontx2/otx2_ethdev_ops.c @@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu) if (rc) return rc; - if (frame_size > RTE_ETHER_MAX_LEN) + if (mtu > RTE_ETHER_MTU) dev->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; else dev->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME;