[v2,04/35] common/mlx5/windows: add DevX UAR getters
Checks
Commit Message
From: Ophir Munk <ophirmu@nvidia.com>
The following getters are added: mlx5_os_get_devx_uar_mmap_offset,
mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr,
mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent of
the Linux implementation in [1].
[1]
commit 8638e19a10aa ("net/mlx5: remove more DV dependencies")
Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/common/mlx5/windows/mlx5_common_os.h | 75 ++++++++++++++++++++++++++++
1 file changed, 75 insertions(+)
Comments
On 12/28/2020 12:32 PM, Tal Shnaiderman wrote:
> From: Ophir Munk <ophirmu@nvidia.com>
>
> The following getters are added: mlx5_os_get_devx_uar_mmap_offset,
> mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr,
> mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent of
> the Linux implementation in [1].
>
> [1]
> commit 8638e19a10aa ("net/mlx5: remove more DV dependencies")
This commit is not in the repo, I guess you mean:
1f66ac5bbe89 ("net/mlx5: remove more Direct Verbs dependencies")
>
> Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
<...>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, January 8, 2021 2:08 PM
> To: Tal Shnaiderman <talshn@nvidia.com>; dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ophir
> Munk <ophirmu@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH v2 04/35] common/mlx5/windows: add DevX
> UAR getters
>
> On 12/28/2020 12:32 PM, Tal Shnaiderman wrote:
> > From: Ophir Munk <ophirmu@nvidia.com>
> >
> > The following getters are added: mlx5_os_get_devx_uar_mmap_offset,
> > mlx5_os_get_devx_uar_base_addr, mlx5_os_get_devx_uar_reg_addr,
> > mlx5_os_get_devx_uar_page_id. This commit is the Windows equivalent
> > of the Linux implementation in [1].
> >
> > [1]
> > commit 8638e19a10aa ("net/mlx5: remove more DV dependencies")
>
> This commit is not in the repo, I guess you mean:
> 1f66ac5bbe89 ("net/mlx5: remove more Direct Verbs dependencies")
>
Correct. Thanks for noticing.
> >
> > Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
>
> <...>
@@ -6,6 +6,7 @@
#define RTE_PMD_MLX5_COMMON_OS_H_
#include <stdio.h>
+#include <sys/types.h>
#include <rte_errno.h>
@@ -15,6 +16,8 @@
#include "mlx5_common_mr.h"
#include "mlx5_win_ext.h"
+#define MLX5_BF_OFFSET 0x800
+
/**
* This API allocates aligned or non-aligned memory. The free can be on either
* aligned or nonaligned memory. To be protected - even though there may be no
@@ -144,6 +147,78 @@ mlx5_os_get_umem_id(void *umem)
return ((struct mlx5_devx_umem *)umem)->umem_id;
}
+/**
+ * Get mmap offset. Given a pointer to an DevX UAR object of type
+ * 'struct mlx5dv_devx_uar *' - return its mmap offset.
+ * In Windows, mmap_offset is unused.
+ *
+ * @param[in] uar
+ * Pointer to UAR object.
+ *
+ * @return
+ * 0 as mmap_offset is unused
+ */
+static inline off_t
+mlx5_os_get_devx_uar_mmap_offset(void *uar)
+{
+ RTE_SET_USED(uar);
+ return 0;
+}
+
+/**
+ * Get base addr pointer. Given a pointer to an UAR object of type
+ * 'struct mlx5dv_devx_uar *' - return its base address.
+ *
+ * @param[in] uar
+ * Pointer to an UAR object.
+ *
+ * @return
+ * The base address if UAR is valid, NULL otherwise.
+ */
+static inline void *
+mlx5_os_get_devx_uar_base_addr(void *uar)
+{
+ if (!uar)
+ return NULL;
+ return ((devx_uar_handle *)uar)->uar_page;
+}
+
+/**
+ * Get reg addr pointer. Given a pointer to an UAR object of type
+ * 'struct mlx5dv_devx_uar *' - return its reg address.
+ *
+ * @param[in] uar
+ * Pointer to an UAR object.
+ *
+ * @return
+ * The reg address if UAR is valid, NULL otherwise.
+ */
+static inline void *
+mlx5_os_get_devx_uar_reg_addr(void *uar)
+{
+ if (!uar)
+ return NULL;
+ return ((char *)((devx_uar_handle *)uar)->uar_page) + MLX5_BF_OFFSET;
+}
+
+/**
+ * Get page id. Given a pointer to an UAR object of type
+ * 'struct mlx5dv_devx_uar *' - return its page id.
+ *
+ * @param[in] uar
+ * Pointer to an UAR object.
+ *
+ * @return
+ * The page id if UAR is valid, 0 otherwise.
+ */
+static inline uint32_t
+mlx5_os_get_devx_uar_page_id(void *uar)
+{
+ if (!uar)
+ return 0;
+ return ((devx_uar_handle *)uar)->uar_index;
+}
+
void *mlx5_os_alloc_pd(void *ctx);
int mlx5_os_dealloc_pd(void *pd);
void *mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access);