diff mbox series

[v2] mlx5: fix __mlx5_bit_off macro warning for Windows

Message ID 20210107114545.12124-1-talshn@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v2] mlx5: fix __mlx5_bit_off macro warning for Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-mellanox-Functional success Functional Testing PASS

Commit Message

Tal Shnaiderman Jan. 7, 2021, 11:45 a.m. UTC 
  While compiling with clang 11 the callers of the
__mlx5_bit_off macro warns on the cast of pointers to
unsigned long which is a smaller int type in Windows.

warning: cast to smaller integer type 'unsigned long'
from 'u8 (*)[16]' [-Wpointer-to-int-cast]

To resolve it the type is changed to uintptr_t to be
compatible for both Linux and Windows.

Fixes: 865a0c15672c ("net/mlx5: add Direct Verbs prepare function")
Cc: stable@dpdk.org

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
v2: change type to uintptr_t [DmitryK]
---
 drivers/common/mlx5/mlx5_prm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matan Azrad Jan. 7, 2021, 12:59 p.m. UTC | #1 
From: Tal Shnaiderman
> While compiling with clang 11 the callers of the __mlx5_bit_off macro warns
> on the cast of pointers to unsigned long which is a smaller int type in Windows.
> 
> warning: cast to smaller integer type 'unsigned long'
> from 'u8 (*)[16]' [-Wpointer-to-int-cast]
> 
> To resolve it the type is changed to uintptr_t to be compatible for both Linux
> and Windows.
> 
> Fixes: 865a0c15672c ("net/mlx5: add Direct Verbs prepare function")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Thomas Monjalon Jan. 12, 2021, 9:45 p.m. UTC | #2 
07/01/2021 13:59, Matan Azrad:
> From: Tal Shnaiderman
> > While compiling with clang 11 the callers of the __mlx5_bit_off macro warns
> > on the cast of pointers to unsigned long which is a smaller int type in Windows.
> > 
> > warning: cast to smaller integer type 'unsigned long'
> > from 'u8 (*)[16]' [-Wpointer-to-int-cast]
> > 
> > To resolve it the type is changed to uintptr_t to be compatible for both Linux
> > and Windows.
> > 
> > Fixes: 865a0c15672c ("net/mlx5: add Direct Verbs prepare function")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Applied to next-net-mlx, thanks.
diff mbox series

Patch

diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index 8c9b53ce10..b6a3a3cfcb 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -601,7 +601,7 @@  typedef uint8_t u8;
 
 #define __mlx5_nullp(typ) ((struct mlx5_ifc_##typ##_bits *)0)
 #define __mlx5_bit_sz(typ, fld) sizeof(__mlx5_nullp(typ)->fld)
-#define __mlx5_bit_off(typ, fld) ((unsigned int)(unsigned long) \
+#define __mlx5_bit_off(typ, fld) ((unsigned int)(uintptr_t) \
 				  (&(__mlx5_nullp(typ)->fld)))
 #define __mlx5_dw_bit_off(typ, fld) (32 - __mlx5_bit_sz(typ, fld) - \
 				    (__mlx5_bit_off(typ, fld) & 0x1f))