diff mbox series

build rte_reciprocal.c on windows and export rte_reciprocal_value_u64

Message ID 1610391337-24080-2-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
State Superseded, archived
Headers
Series build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Tyler Retzlaff Jan. 11, 2021, 6:55 p.m. UTC 
  From: Tyler Retzlaff <roretzla@microsoft.com>

Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
 lib/librte_eal/common/meson.build  | 1 +
 lib/librte_eal/rte_eal_exports.def | 1 +
 2 files changed, 2 insertions(+)

Comments

Dmitry Kozlyuk Jan. 11, 2021, 8:29 p.m. UTC | #1 
Subject line is too long and doesn't follow the guidelines:

https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line

It could be: "eal/windows: build rte_reciprocal functions" or better.

> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 4597eb8cd..ba1443dc2 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -326,3 +326,4 @@ EXPORTS
>  	rte_mem_map
>  	rte_mem_page_size
>  	rte_mem_unmap
> +	rte_reciprocal_value_u64

+ rte_reciprocal_value

Please keep the order in .def same as in .map.
diff mbox series

Patch

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 39abf7a0a..9c6f18eb8 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -34,6 +34,7 @@  if is_windows
 		'rte_malloc.c',
 		'eal_common_timer.c',
 		'rte_service.c',
+		'rte_reciprocal.c',
 	)
 	subdir_done()
 endif
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 4597eb8cd..ba1443dc2 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -326,3 +326,4 @@  EXPORTS
 	rte_mem_map
 	rte_mem_page_size
 	rte_mem_unmap
+	rte_reciprocal_value_u64