[v4] drivers/common: enable Windows common mlx5 compilation

Message ID 20210112125839.11856-1-talshn@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v4] drivers/common: enable Windows common mlx5 compilation |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Tal Shnaiderman Jan. 12, 2021, 12:58 p.m. UTC
  From: Ophir Munk <ophirmu@nvidia.com>

Prior to this commit meson did not progress beyond directory
drivers/common for Windows compilations.  This commit enables drivers
compilation under this directory.

Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
v3: change commit place with dependencies.
v4: remove unneeded change in common/meson.build [Thomas]
Depends-on: patch-86125 ("mlx5: fix __mlx5_bit_off macro warning for Windows")
---
 drivers/common/mlx5/meson.build | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Thomas Monjalon Jan. 13, 2021, 10:07 p.m. UTC | #1
12/01/2021 13:58, Tal Shnaiderman:
> From: Ophir Munk <ophirmu@nvidia.com>
> 
> Prior to this commit meson did not progress beyond directory
> drivers/common for Windows compilations.  This commit enables drivers
> compilation under this directory.

This commit is not changing compilation of drivers/common/*
Changing the commit log to:
"Enable mlx5 PMD on Windows with clang compilation."

> Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Applied to next-net-mlx, thanks
  

Patch

diff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build
index 3dacc6f683..3047b455cf 100644
--- a/drivers/common/mlx5/meson.build
+++ b/drivers/common/mlx5/meson.build
@@ -1,9 +1,9 @@ 
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright 2019 Mellanox Technologies, Ltd
 
-if not is_linux
+if not (is_linux or (is_windows and is_ms_linker))
 	build = false
-	reason = 'only supported on Linux'
+	reason = 'only supported on Linux and Windows build with clang'
 	subdir_done()
 endif