devtools: remove ethdev ABI exception
Checks
Commit Message
Now that the ethernet driver dev_ops structure definition is not
exported anymore, there is no need for an exception.
abidiff will only consider structures defined in the installed headers
(passed with --headers-dirX options).
Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/libabigail.abignore | 2 --
1 file changed, 2 deletions(-)
Comments
On 2/1/2021 6:08 PM, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 2/1/21 7:08 PM, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/libabigail.abignore | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index ab5db240e7..6c0b38984e 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,8 +13,6 @@
> name_regexp = _pmd_info$
>
> ; Explicit ignore for driver-only ABI
> -[suppress_type]
> - name = eth_dev_ops
> [suppress_function]
> name_regexp = rte_vdev_(|un)register
>
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
On 01/02/2021 18:08, David Marchand wrote:
> Now that the ethernet driver dev_ops structure definition is not
> exported anymore, there is no need for an exception.
> abidiff will only consider structures defined in the installed headers
> (passed with --headers-dirX options).
>
> Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> devtools/libabigail.abignore | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> index ab5db240e7..6c0b38984e 100644
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> @@ -13,8 +13,6 @@
> name_regexp = _pmd_info$
>
> ; Explicit ignore for driver-only ABI
> -[suppress_type]
> - name = eth_dev_ops
> [suppress_function]
> name_regexp = rte_vdev_(|un)register
>
eth_dev_ops structure are not exported, so there is no symbol that is actually
changing here. The type definition _only_ will be in DPDK 20.11 public headers,
but is removed in DPDK 21.02.
I find it a little strange that libabigail is baulking when the type is changed
(see 1fe3eef5e9b) but not when it is entirely removed?
Ray K
01/02/2021 20:03, Ferruh Yigit:
> On 2/1/2021 6:08 PM, David Marchand wrote:
> > Now that the ethernet driver dev_ops structure definition is not
> > exported anymore, there is no need for an exception.
> > abidiff will only consider structures defined in the installed headers
> > (passed with --headers-dirX options).
> >
> > Fixes: df96fd0d7395 ("ethdev: make driver-only headers private")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
@@ -13,8 +13,6 @@
name_regexp = _pmd_info$
; Explicit ignore for driver-only ABI
-[suppress_type]
- name = eth_dev_ops
[suppress_function]
name_regexp = rte_vdev_(|un)register