diff mbox series

net/mlx5/linux: fix missing firmware version copying

Message ID 20210205090045.12047-1-xvojan00@stud.fit.vutbr.cz (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5/linux: fix missing firmware version copying |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/iol-testing warning Testing issues
ci/checkpatch success coding style OK

Commit Message

Kamil Vojanec Feb. 5, 2021, 9 a.m. UTC 
  This patch fixes a bug where firmware version was not
copied from ibv_device_attr structure into mlx5_dev_attr
structure, resulting in inability to read firmware
version.

Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
---
 drivers/net/mlx5/linux/mlx5_os.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Matan Azrad May 6, 2021, 9:34 a.m. UTC | #1 
From: Kamil Vojanec
> This patch fixes a bug where firmware version was not copied from
> ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability
> to read firmware version.
> 
> Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
Acked-by: Matan Azrad <matan@nvidia.com>



> ---
>  drivers/net/mlx5/linux/mlx5_os.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index a8cc5f311..fa35c06e7 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -152,6 +152,7 @@ mlx5_os_get_dev_attr(void *ctx, struct
> mlx5_dev_attr *device_attr)  #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
>         device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
> #endif
> +       strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver,
> + sizeof(device_attr->fw_ver));
> 
>         return err;
>  }
> --
> 2.17.1
Raslan Darawsheh May 10, 2021, 12:26 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Kamil Vojanec
> Sent: Friday, February 5, 2021 11:01 AM
> To: dev@dpdk.org
> Cc: viktorin@cesnet.cz; Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version
> copying
> 
> This patch fixes a bug where firmware version was not copied from
> ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability
> to read firmware version.
> 
Added missing: 
Fixes: e85f623e13ea ("net/mlx5: remove attributes dependency on Verbs")
Cc: stable@dpdk.org

> Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
> ---

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index a8cc5f311..fa35c06e7 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -152,6 +152,7 @@  mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr)
 #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
 	device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
 #endif
+	strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(device_attr->fw_ver));
 
 	return err;
 }