diff mbox series

[kmods] windows/netuio: add vmxnet3 device ID

Message ID 20210221005149.10576-1-dmitry.kozliuk@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [kmods] windows/netuio: add vmxnet3 device ID |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Dmitry Kozlyuk Feb. 21, 2021, 12:51 a.m. UTC 
  Add device ID of VMWare Paravirtualized Ethernet v3.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Marchand Feb. 22, 2021, 9:20 a.m. UTC | #1 
On Sun, Feb 21, 2021 at 1:52 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> Add device ID of VMWare Paravirtualized Ethernet v3.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
>  windows/netuio/netuio.inf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index 666a69c..db97366 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -42,6 +42,7 @@ HKR,,Icon,,-5
>  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
>
>  [netuio_Device.NT]
>  CopyFiles=Drivers_Dir
> @@ -99,6 +100,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>  Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>  Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>  Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +vmxnet3.Description = "VMWare Paravirtualized Ethernet v3"
>  netuio.SVCDESC = "netuio Service"
>
>  [DMAr.reg]

Is there no other way than hardcoding those values in the driver?
Something à la driverctl?
Tyler Retzlaff Feb. 22, 2021, 5:54 p.m. UTC | #2 
On Mon, Feb 22, 2021 at 10:20:41AM +0100, David Marchand wrote:

> > diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> > index 666a69c..db97366 100644
> > --- a/windows/netuio/netuio.inf
> > +++ b/windows/netuio/netuio.inf
> > @@ -42,6 +42,7 @@ HKR,,Icon,,-5
> >  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
> >  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
> >  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> > +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
> >
> 
> Is there no other way than hardcoding those values in the driver?
> Something à la driverctl?

This is how support for vendor / device is expressed for a driver
to the Windows PnP subsystem.  The device ids listed in the .inf
file are used to match the driver when the device is enumerated.

It's not really hardcoded though (not compiled anyway) so the list
of ids in a .inf can be changed without recompiled it is just a text
file.

> 
> 
> -- 
> David Marchand
Nick Connolly March 1, 2021, 9:51 p.m. UTC | #3 
> +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
>
Acked-by: Nick Connolly <nick.connolly@mayadata.io>

PCI hardware IDs verified against:
https://devicehunt.com/view/type/pci/vendor/15AD/device/07B0
Thomas Monjalon March 17, 2021, 9:54 a.m. UTC | #4 
01/03/2021 22:51, Nick Connolly:
> 
> > +%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
> >
> Acked-by: Nick Connolly <nick.connolly@mayadata.io>
> 
> PCI hardware IDs verified against:
> https://devicehunt.com/view/type/pci/vendor/15AD/device/07B0

Applied, thanks
diff mbox series

Patch

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index 666a69c..db97366 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -42,6 +42,7 @@  HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%vmxnet3.Description%=netuio_Device, PCI\VEN_15AD&DEV_07B0
 
 [netuio_Device.NT]
 CopyFiles=Drivers_Dir
@@ -99,6 +100,7 @@  Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+vmxnet3.Description = "VMWare Paravirtualized Ethernet v3"
 netuio.SVCDESC = "netuio Service"
 
 [DMAr.reg]