[PATCH-V4] config/arm: restore support for Qualcomm servers

Message ID 20210429100707.20757-1-thierry.herbelot@6wind.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series [PATCH-V4] config/arm: restore support for Qualcomm servers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thierry Herbelot April 29, 2021, 10:07 a.m. UTC
  From the documentation:
"The SoC configuration is a combination of implementer and CPU part number
 configuration and SoC-specific configuration."

Align Qualcomm SoC configuration with the configuration of other server
SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
implementer configuration.

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V4:
- use a more specific SoC name
V3:
- include doc patch
- remove Fixes line
V2:
- use the right original commit in Fixes
---
 config/arm/meson.build                              | 8 ++++++++
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 +
 2 files changed, 9 insertions(+)
  

Comments

Ruifeng Wang April 29, 2021, 3:03 p.m. UTC | #1
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, April 29, 2021 6:07 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
> Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> Subject: [PATCH-V4] config/arm: restore support for Qualcomm servers
> 
> From the documentation:
> "The SoC configuration is a combination of implementer and CPU part
> number  configuration and SoC-specific configuration."
> 
> Align Qualcomm SoC configuration with the configuration of other server
> SoCs (eMAG, Kunpeng 9x0): add a soc configuration to the existing
> implementer configuration.
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V4:
> - use a more specific SoC name
> V3:
> - include doc patch
> - remove Fixes line
> V2:
> - use the right original commit in Fixes
> ---
>  config/arm/meson.build                              | 8 ++++++++
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> 22cd81319c06..162a19e0a383 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -223,6 +223,13 @@ soc_bluefield = {
>      'numa': false
>  }
> 
> +soc_centriq2400 = {
> +    'description': 'Qualcomm Centriq 2400',
> +    'implementer': '0x51',
> +    'part_number': '0xc00',
> +    'numa': false
> +}
> +
>  soc_cn10k = {
>      'description' : 'Marvell OCTEON 10',
>      'implementer' : '0x41',
> @@ -325,6 +332,7 @@ socs = {
>      'generic': soc_generic,
>      'armada': soc_armada,
>      'bluefield': soc_bluefield,
> +    'centriq2400': soc_centriq2400,
>      'cn10k' : soc_cn10k,
>      'dpaa': soc_dpaa,
>      'emag': soc_emag,
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index 3e170436cd4f..90f6472780d7 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -202,6 +202,7 @@ Substitute <target_soc> with one of the supported
> SoCs::
>     generic:     Generic un-optimized build for all aarch64 machines.
>     armada:      Marvell ARMADA
>     bluefield:   NVIDIA BlueField
> +   centriq2400: Qualcomm Centriq 2400

There is a patch to improve documentation:
http://patches.dpdk.org/project/dpdk/patch/20210429070751.6065-1-david.marchand@redhat.com/
May be you can make your patch based on that one.

Thanks.
>     cn10k:       Marvell OCTEON 10
>     dpaa:        NXP DPAA
>     emag:        Ampere eMAG
> --
> 2.29.2
  

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 22cd81319c06..162a19e0a383 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -223,6 +223,13 @@  soc_bluefield = {
     'numa': false
 }
 
+soc_centriq2400 = {
+    'description': 'Qualcomm Centriq 2400',
+    'implementer': '0x51',
+    'part_number': '0xc00',
+    'numa': false
+}
+
 soc_cn10k = {
     'description' : 'Marvell OCTEON 10',
     'implementer' : '0x41',
@@ -325,6 +332,7 @@  socs = {
     'generic': soc_generic,
     'armada': soc_armada,
     'bluefield': soc_bluefield,
+    'centriq2400': soc_centriq2400,
     'cn10k' : soc_cn10k,
     'dpaa': soc_dpaa,
     'emag': soc_emag,
diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index 3e170436cd4f..90f6472780d7 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -202,6 +202,7 @@  Substitute <target_soc> with one of the supported SoCs::
    generic:     Generic un-optimized build for all aarch64 machines.
    armada:      Marvell ARMADA
    bluefield:   NVIDIA BlueField
+   centriq2400: Qualcomm Centriq 2400
    cn10k:       Marvell OCTEON 10
    dpaa:        NXP DPAA
    emag:        Ampere eMAG