[v1] net/i40e: fix set rss hash function invalid
Checks
Commit Message
i40e can support following rss hash function types: default (toeplitz),
symmetric toeplitz, and simple_xor. However, when filter engine parses
pattern action, it only supports symmetric toeplitz & default (toeplitz).
Delete the hash function limitation when parsing pattern action.
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/i40e/i40e_hash.c | 5 -----
1 file changed, 5 deletions(-)
Comments
> -----Original Message-----
> From: Yang, SteveX <stevex.yang@intel.com>
> Sent: Friday, June 11, 2021 9:35 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [PATCH v1] net/i40e: fix set rss hash function invalid
>
> i40e can support following rss hash function types: default (toeplitz),
> symmetric toeplitz, and simple_xor. However, when filter engine parses
> pattern action, it only supports symmetric toeplitz & default (toeplitz).
>
> Delete the hash function limitation when parsing pattern action.
Missed fix line.
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
> drivers/net/i40e/i40e_hash.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
> index b1cb24f437..bd734722d9 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct
> rte_eth_dev *dev,
>
> if (rss_act->func ==
> RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
> rss_conf->symmetric_enable = true;
> - else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
> - return rte_flow_error_set(error, -EINVAL,
> -
> RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> - NULL,
> - "Only symmetric TOEPLITZ
> supported when pattern specified");
Do we any other error info if rss_act->func != default or rss_act->func != simple_xor?
>
> if (!i40e_hash_validate_rss_types(rss_act->types))
> return rte_flow_error_set(error, EINVAL,
> --
> 2.27.0
@@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev,
if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
rss_conf->symmetric_enable = true;
- else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
- return rte_flow_error_set(error, -EINVAL,
- RTE_FLOW_ERROR_TYPE_ACTION_CONF,
- NULL,
- "Only symmetric TOEPLITZ supported when pattern specified");
if (!i40e_hash_validate_rss_types(rss_act->types))
return rte_flow_error_set(error, EINVAL,