[2/2] examples/ipsec-secgw: add UDP encapsulation for inline protocol
Checks
Commit Message
Adds support to allow udp-encap option for
RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also.
Signed-off-by: Srujana Challa <schalla@marvell.com>
---
examples/ipsec-secgw/sa.c | 31 ++++++++++++++++++-------------
1 file changed, 18 insertions(+), 13 deletions(-)
Comments
> Subject: [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for
> inline protocol
>
> Adds support to allow udp-encap option for
> RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also.
>
> Signed-off-by: Srujana Challa <schalla@marvell.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>
@Konstantin Ananyev: Any comments on this patch?
>
> > Subject: [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for
> > inline protocol
> >
> > Adds support to allow udp-encap option for
> > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also.
> >
> > Signed-off-by: Srujana Challa <schalla@marvell.com>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
>
> @Konstantin Ananyev: Any comments on this patch?
No I don't have any, looks ok to me.
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> >
> > > Subject: [PATCH 2/2] examples/ipsec-secgw: add UDP encapsulation for
> > > inline protocol
> > >
> > > Adds support to allow udp-encap option for
> > > RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL mode also.
> > >
> > > Signed-off-by: Srujana Challa <schalla@marvell.com>
> > > ---
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> > @Konstantin Ananyev: Any comments on this patch?
>
> No I don't have any, looks ok to me.
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Series Applied to dpdk-next-crypto
Thanks.
@@ -759,20 +759,25 @@ parse_sa_tokens(char **tokens, uint32_t n_tokens,
continue;
}
if (strcmp(tokens[ti], "udp-encap") == 0) {
- APP_CHECK(ips->type ==
- RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL,
- status, "UDP encapsulation is allowed if the "
- "session is of type lookaside-protocol-offload "
- "only.");
- if (status->status < 0)
- return;
- APP_CHECK_PRESENCE(udp_encap_p, tokens[ti], status);
- if (status->status < 0)
- return;
+ switch (ips->type) {
+ case RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL:
+ case RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL:
+ APP_CHECK_PRESENCE(udp_encap_p, tokens[ti],
+ status);
+ if (status->status < 0)
+ return;
- rule->udp_encap = 1;
- app_sa_prm.udp_encap = 1;
- udp_encap_p = 1;
+ rule->udp_encap = 1;
+ app_sa_prm.udp_encap = 1;
+ udp_encap_p = 1;
+ break;
+ default:
+ APP_CHECK(0, status,
+ "UDP encapsulation not supported for "
+ "security session type %d",
+ ips->type);
+ return;
+ }
continue;
}