[4/4] doc: note that testpmd on mlx5 has dedicated queues problem

Message ID 20210721155918.188867-5-xhavli56@stud.fit.vutbr.cz (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series doc: update RTE flow rule and bonding related info |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Havlík Martin July 21, 2021, 3:59 p.m. UTC
  In bonding mode 4 (8023ad), dedicated queues are not working
on mlx5 NICs.

Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Slava Ovsiienko March 6, 2023, 3:21 p.m. UTC | #1
Hi, Martin

Is this issue resolved by:  http://git.dpdk.org/dpdk/commit/?id=f66323717e  ?

Should we archive the patch?

With best regards,
Slava



> -----Original Message-----
> From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> Sent: среда, 21 июля 2021 г. 18:59
> To: xhavli56@stud.fit.vutbr.cz; Xiaoyun Li <xiaoyun.li@intel.com>; Ferruh Yigit
> <ferruh.yigit@intel.com>; Andrew Rybchenko <arybchenko@solarflare.com>;
> Ajit Khaparde <ajit.khaparde@broadcom.com>; Haiyue Wang
> <haiyue.wang@intel.com>; Ori Kam <orika@nvidia.com>; Haifei Luo
> <haifeil@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Andrey
> Vesnovaty <andreyv@nvidia.com>; Bing Zhao <bingz@nvidia.com>;
> Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Gregory Etelson
> <getelson@nvidia.com>; Li Zhang <lizh@nvidia.com>
> Cc: dev@dpdk.org; Jan Viktorin <viktorin@cesnet.cz>
> Subject: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues
> problem
> 
> In bonding mode 4 (8023ad), dedicated queues are not working on mlx5 NICs.
> 
> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> ---
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 2c43719ad3..8a6edc2bad 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad)::
> 
>     testpmd> set bonding lacp dedicated_queues (port_id) (enable|disable)
> 
> +.. note::
> +   Dedicated queues `do not currently work
> +   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
> 
>  set bonding agg_mode
>  ~~~~~~~~~~~~~~~~~~~~
> --
> 2.27.0
  
Havlík Martin March 7, 2023, 9 a.m. UTC | #2
Hi Slava,

as I no longer work on the DPDK centered project which led me to 
encounter said issue, I am no longer in touch with changes made to 
net/bonding and moreover I don't have access to resources to test the 
current state of things.

But that aside, the linked commit seems to fix the issue (again, cannot 
test it myself but I'll trust the time passed since the commit without 
further changes).

If archiving is what is done to obsolete patches, then yes, go ahead, 
please.

Wish you all the best,
Martin

Dne 2023-03-06 16:21, Slava Ovsiienko napsal:
> Hi, Martin
> 
> Is this issue resolved by:  
> http://git.dpdk.org/dpdk/commit/?id=f66323717e  ?
> 
> Should we archive the patch?
> 
> With best regards,
> Slava
> 
> 
> 
>> -----Original Message-----
>> From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
>> Sent: среда, 21 июля 2021 г. 18:59
>> To: xhavli56@stud.fit.vutbr.cz; Xiaoyun Li <xiaoyun.li@intel.com>; 
>> Ferruh Yigit
>> <ferruh.yigit@intel.com>; Andrew Rybchenko 
>> <arybchenko@solarflare.com>;
>> Ajit Khaparde <ajit.khaparde@broadcom.com>; Haiyue Wang
>> <haiyue.wang@intel.com>; Ori Kam <orika@nvidia.com>; Haifei Luo
>> <haifeil@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Andrey
>> Vesnovaty <andreyv@nvidia.com>; Bing Zhao <bingz@nvidia.com>;
>> Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Gregory Etelson
>> <getelson@nvidia.com>; Li Zhang <lizh@nvidia.com>
>> Cc: dev@dpdk.org; Jan Viktorin <viktorin@cesnet.cz>
>> Subject: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated 
>> queues
>> problem
>> 
>> In bonding mode 4 (8023ad), dedicated queues are not working on mlx5 
>> NICs.
>> 
>> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
>> ---
>>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> index 2c43719ad3..8a6edc2bad 100644
>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>> @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad)::
>> 
>>     testpmd> set bonding lacp dedicated_queues (port_id) 
>> (enable|disable)
>> 
>> +.. note::
>> +   Dedicated queues `do not currently work
>> +   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
>> 
>>  set bonding agg_mode
>>  ~~~~~~~~~~~~~~~~~~~~
>> --
>> 2.27.0
  
Jan Viktorin March 7, 2023, 9:37 a.m. UTC | #3
Hello all,

Mario (CC) will look at this.

H.

On Tue, 07 Mar 2023 10:00:35 +0100
Havlík Martin <xhavli56@stud.fit.vutbr.cz> wrote:

> Hi Slava,
> 
> as I no longer work on the DPDK centered project which led me to 
> encounter said issue, I am no longer in touch with changes made to 
> net/bonding and moreover I don't have access to resources to test the 
> current state of things.
> 
> But that aside, the linked commit seems to fix the issue (again,
> cannot test it myself but I'll trust the time passed since the commit
> without further changes).
> 
> If archiving is what is done to obsolete patches, then yes, go ahead, 
> please.
> 
> Wish you all the best,
> Martin
> 
> Dne 2023-03-06 16:21, Slava Ovsiienko napsal:
> > Hi, Martin
> > 
> > Is this issue resolved by:  
> > http://git.dpdk.org/dpdk/commit/?id=f66323717e  ?
> > 
> > Should we archive the patch?
> > 
> > With best regards,
> > Slava
> > 
> > 
> >   
> >> -----Original Message-----
> >> From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> >> Sent: среда, 21 июля 2021 г. 18:59
> >> To: xhavli56@stud.fit.vutbr.cz; Xiaoyun Li <xiaoyun.li@intel.com>; 
> >> Ferruh Yigit
> >> <ferruh.yigit@intel.com>; Andrew Rybchenko 
> >> <arybchenko@solarflare.com>;
> >> Ajit Khaparde <ajit.khaparde@broadcom.com>; Haiyue Wang
> >> <haiyue.wang@intel.com>; Ori Kam <orika@nvidia.com>; Haifei Luo
> >> <haifeil@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> >> Andrey Vesnovaty <andreyv@nvidia.com>; Bing Zhao
> >> <bingz@nvidia.com>; Jiawei(Jonny) Wang <jiaweiw@nvidia.com>;
> >> Gregory Etelson <getelson@nvidia.com>; Li Zhang <lizh@nvidia.com>
> >> Cc: dev@dpdk.org; Jan Viktorin <viktorin@cesnet.cz>
> >> Subject: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated 
> >> queues
> >> problem
> >> 
> >> In bonding mode 4 (8023ad), dedicated queues are not working on
> >> mlx5 NICs.
> >> 
> >> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> >> ---
> >>  doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
> >>  1 file changed, 3 insertions(+)
> >> 
> >> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >> index 2c43719ad3..8a6edc2bad 100644
> >> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >> @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad)::
> >>   
> >>     testpmd> set bonding lacp dedicated_queues (port_id)   
> >> (enable|disable)
> >> 
> >> +.. note::
> >> +   Dedicated queues `do not currently work
> >> +   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
> >> 
> >>  set bonding agg_mode
> >>  ~~~~~~~~~~~~~~~~~~~~
> >> --
> >> 2.27.0
  
Mário Kuka March 7, 2023, 10:26 a.m. UTC | #4
Hello Slava,

I confirm that the patch http://git.dpdk.org/dpdk/commit/?id=f66323717e 
has resolved this issue.
I have tested that after applying the patch, the problem no longer occurs.

With best regards,
Mário

On 07/03/2023 10:37, Jan Viktorin wrote:
> Hello all,
>
> Mario (CC) will look at this.
>
> H.
>
> On Tue, 07 Mar 2023 10:00:35 +0100
> Havlík Martin <xhavli56@stud.fit.vutbr.cz> wrote:
>
>> Hi Slava,
>>
>> as I no longer work on the DPDK centered project which led me to
>> encounter said issue, I am no longer in touch with changes made to
>> net/bonding and moreover I don't have access to resources to test the
>> current state of things.
>>
>> But that aside, the linked commit seems to fix the issue (again,
>> cannot test it myself but I'll trust the time passed since the commit
>> without further changes).
>>
>> If archiving is what is done to obsolete patches, then yes, go ahead,
>> please.
>>
>> Wish you all the best,
>> Martin
>>
>> Dne 2023-03-06 16:21, Slava Ovsiienko napsal:
>>> Hi, Martin
>>>
>>> Is this issue resolved by:
>>> http://git.dpdk.org/dpdk/commit/?id=f66323717e  ?
>>>
>>> Should we archive the patch?
>>>
>>> With best regards,
>>> Slava
>>>
>>>
>>>    
>>>> -----Original Message-----
>>>> From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
>>>> Sent: среда, 21 июля 2021 г. 18:59
>>>> To: xhavli56@stud.fit.vutbr.cz; Xiaoyun Li <xiaoyun.li@intel.com>;
>>>> Ferruh Yigit
>>>> <ferruh.yigit@intel.com>; Andrew Rybchenko
>>>> <arybchenko@solarflare.com>;
>>>> Ajit Khaparde <ajit.khaparde@broadcom.com>; Haiyue Wang
>>>> <haiyue.wang@intel.com>; Ori Kam <orika@nvidia.com>; Haifei Luo
>>>> <haifeil@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
>>>> Andrey Vesnovaty <andreyv@nvidia.com>; Bing Zhao
>>>> <bingz@nvidia.com>; Jiawei(Jonny) Wang <jiaweiw@nvidia.com>;
>>>> Gregory Etelson <getelson@nvidia.com>; Li Zhang <lizh@nvidia.com>
>>>> Cc: dev@dpdk.org; Jan Viktorin <viktorin@cesnet.cz>
>>>> Subject: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated
>>>> queues
>>>> problem
>>>>
>>>> In bonding mode 4 (8023ad), dedicated queues are not working on
>>>> mlx5 NICs.
>>>>
>>>> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
>>>> ---
>>>>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
>>>>   1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>>>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>>>> index 2c43719ad3..8a6edc2bad 100644
>>>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>>>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
>>>> @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad)::
>>>>    
>>>>      testpmd> set bonding lacp dedicated_queues (port_id)
>>>> (enable|disable)
>>>>
>>>> +.. note::
>>>> +   Dedicated queues `do not currently work
>>>> +   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
>>>>
>>>>   set bonding agg_mode
>>>>   ~~~~~~~~~~~~~~~~~~~~
>>>> --
>>>> 2.27.0
  
Slava Ovsiienko March 7, 2023, 10:29 a.m. UTC | #5
Hi,

Thank you, Mario, for confirming.
So, patch is not actual anymore.

With best regards,
Slava

> -----Original Message-----
> From: Mário Kuka <kuka@cesnet.cz>
> Sent: вторник, 7 марта 2023 г. 12:26
> To: Jan Viktorin <viktorin@cesnet.cz>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: Havlík Martin <xhavli56@stud.fit.vutbr.cz>; Xiaoyun Li
> <xiaoyun.li@intel.com>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
> Rybchenko <arybchenko@solarflare.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Haiyue Wang <haiyue.wang@intel.com>; Ori
> Kam <orika@nvidia.com>; Haifei Luo <haifeil@nvidia.com>; Andrey Vesnovaty
> <andreyv@nvidia.com>; Bing Zhao <bingz@nvidia.com>; Jiawei(Jonny) Wang
> <jiaweiw@nvidia.com>; Gregory Etelson <getelson@nvidia.com>; Li Zhang
> <lizh@nvidia.com>; dev@dpdk.org
> Subject: Re: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated queues
> problem
> 
> Hello Slava,
> 
> I confirm that the patch http://git.dpdk.org/dpdk/commit/?id=f66323717e
> has resolved this issue.
> I have tested that after applying the patch, the problem no longer occurs.
> 
> With best regards,
> Mário
> 
> On 07/03/2023 10:37, Jan Viktorin wrote:
> > Hello all,
> >
> > Mario (CC) will look at this.
> >
> > H.
> >
> > On Tue, 07 Mar 2023 10:00:35 +0100
> > Havlík Martin <xhavli56@stud.fit.vutbr.cz> wrote:
> >
> >> Hi Slava,
> >>
> >> as I no longer work on the DPDK centered project which led me to
> >> encounter said issue, I am no longer in touch with changes made to
> >> net/bonding and moreover I don't have access to resources to test the
> >> current state of things.
> >>
> >> But that aside, the linked commit seems to fix the issue (again,
> >> cannot test it myself but I'll trust the time passed since the commit
> >> without further changes).
> >>
> >> If archiving is what is done to obsolete patches, then yes, go ahead,
> >> please.
> >>
> >> Wish you all the best,
> >> Martin
> >>
> >> Dne 2023-03-06 16:21, Slava Ovsiienko napsal:
> >>> Hi, Martin
> >>>
> >>> Is this issue resolved by:
> >>> http://git.dpdk.org/dpdk/commit/?id=f66323717e  ?
> >>>
> >>> Should we archive the patch?
> >>>
> >>> With best regards,
> >>> Slava
> >>>
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> >>>> Sent: среда, 21 июля 2021 г. 18:59
> >>>> To: xhavli56@stud.fit.vutbr.cz; Xiaoyun Li <xiaoyun.li@intel.com>;
> >>>> Ferruh Yigit
> >>>> <ferruh.yigit@intel.com>; Andrew Rybchenko
> >>>> <arybchenko@solarflare.com>;
> >>>> Ajit Khaparde <ajit.khaparde@broadcom.com>; Haiyue Wang
> >>>> <haiyue.wang@intel.com>; Ori Kam <orika@nvidia.com>; Haifei Luo
> >>>> <haifeil@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> >>>> Andrey Vesnovaty <andreyv@nvidia.com>; Bing Zhao
> >>>> <bingz@nvidia.com>; Jiawei(Jonny) Wang <jiaweiw@nvidia.com>;
> >>>> Gregory Etelson <getelson@nvidia.com>; Li Zhang <lizh@nvidia.com>
> >>>> Cc: dev@dpdk.org; Jan Viktorin <viktorin@cesnet.cz>
> >>>> Subject: [PATCH 4/4] doc: note that testpmd on mlx5 has dedicated
> >>>> queues
> >>>> problem
> >>>>
> >>>> In bonding mode 4 (8023ad), dedicated queues are not working on
> >>>> mlx5 NICs.
> >>>>
> >>>> Signed-off-by: Martin Havlik <xhavli56@stud.fit.vutbr.cz>
> >>>> ---
> >>>>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 +++
> >>>>   1 file changed, 3 insertions(+)
> >>>>
> >>>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> index 2c43719ad3..8a6edc2bad 100644
> >>>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> >>>> @@ -2603,6 +2603,9 @@ when in mode 4 (link-aggregation-802.3ad)::
> >>>>
> >>>>      testpmd> set bonding lacp dedicated_queues (port_id)
> >>>> (enable|disable)
> >>>>
> >>>> +.. note::
> >>>> +   Dedicated queues `do not currently work
> >>>> +   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
> >>>>
> >>>>   set bonding agg_mode
> >>>>   ~~~~~~~~~~~~~~~~~~~~
> >>>> --
> >>>> 2.27.0
  

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 2c43719ad3..8a6edc2bad 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -2603,6 +2603,9 @@  when in mode 4 (link-aggregation-802.3ad)::
 
    testpmd> set bonding lacp dedicated_queues (port_id) (enable|disable)
 
+.. note::
+   Dedicated queues `do not currently work
+   <https://bugs.dpdk.org/show_bug.cgi?id=759>`__ on mlx5 NICs.
 
 set bonding agg_mode
 ~~~~~~~~~~~~~~~~~~~~