[V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps
Checks
Context |
Check |
Description |
ci/Intel-dts-test |
success
|
Testing OK
|
Commit Message
*.dpdk cannot guarantee the operation after destroy the rule,
so remove destroy rule test steps.
Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
v2:fix typo issue
.../cvl_advanced_rss_pppoe_test_plan.rst | 16 ---------------
tests/TestSuite_cvl_advanced_rss_pppoe.py | 20 -------------------
2 files changed, 36 deletions(-)
Comments
> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Friday, August 6, 2021 2:23 AM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
>
Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年8月6日 2:23
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule
> test steps
>
> *.dpdk cannot guarantee the operation after destroy the rule, so remove
> destroy rule test steps.
>
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
I think because of the reason, multiple cases/suites/plans should be changed accordingly.
It is strongly requested to include them in the same patch series.
thanks
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年8月5日 17:56
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
>
>
> > -----Original Message-----
> > From: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Sent: Friday, August 6, 2021 2:23 AM
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> > rule test steps
> >
>
> Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
Applied
@@ -4278,14 +4278,6 @@ Test case: MAC_PPPOE_IPV4_UDP_PAY_symmetric
check the hash values of the two packets are different.
-6. destroy the rule::
-
- testpmd> flow destroy 0 rule 0
- testpmd> flow list 0
-
- check the rule not exists in the list.
- repeat step 4, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
- check the hash value is changed.
Test case: MAC_PPPOE_IPV4_TCP_PAY_symmetric
===========================================
@@ -4540,14 +4532,6 @@ Test case: MAC_PPPOE_IPV6_UDP_PAY_symmetric
check the hash values of the two packets are different.
-6. destroy the rule::
-
- testpmd> flow destroy 0 rule 0
- testpmd> flow list 0
-
- check the rule not exists in the list.
- repeat step 3, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
- check the hash values are changed.
Test case: MAC_PPPOE_IPV6_TCP_PAY_symmetric
===========================================
@@ -3780,16 +3780,6 @@ mac_pppoe_ipv6_udp_pay_symmetric = {
'action': {'check_hash_different': 'mac_ipv6_udp_pay_mismatch'},
},
],
- 'post-test': [
- {
- 'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][0],
- 'action': {'save_hash': 'mac_pppoe_ipv6_udp_pay_match_post'},
- },
- {
- 'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][1:],
- 'action': {'check_hash_different': 'mac_pppoe_ipv6_udp_pay_match_post'},
- },
- ],
}
mac_pppoe_ipv6_pay_symmetric_packets = {
@@ -4063,16 +4053,6 @@ mac_pppoe_ipv4_udp_pay_symmetric = {
'action': {'check_hash_different': 'mac_ipv4_udp_pay_mismatch'},
},
],
- 'post-test': [
- {
- 'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][0],
- 'action': {'save_hash': 'mac_ipv4_udp_pay_match_post'},
- },
- {
- 'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][1:],
- 'action': {'check_hash_different': 'mac_ipv4_udp_pay_match_post'},
- },
- ],
}
mac_pppoe_ipv4_tcp_pay_symmetric_packets = {