diff mbox series

[2/4] bus/fslmc: remove experimental tag from API

Message ID 20210903071714.16798-2-nipun.gupta@nxp.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [1/4] bus/dpaa: remove experimental tag and move to internal |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Nipun Gupta Sept. 3, 2021, 7:17 a.m. UTC 
  This API was introduced in 19.08, therefore removing
experimental tag to promote them to stable state.

Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/fslmc/fslmc_vfio.h | 1 -
 drivers/bus/fslmc/version.map  | 4 +++-
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Hemant Agrawal Sept. 9, 2021, 7:11 a.m. UTC | #1 
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

> -----Original Message-----
> From: Nipun Gupta <nipun.gupta@nxp.com>
> Sent: Friday, September 3, 2021 12:47 PM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin
> Saxena (OSS) <sachin.saxena@oss.nxp.com>; david.marchand@redhat.com;
> Nipun Gupta <nipun.gupta@nxp.com>
> Subject: [PATCH 2/4] bus/fslmc: remove experimental tag from API
> Importance: High
> 
> This API was introduced in 19.08, therefore removing experimental tag to
> promote them to stable state.
> 
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  drivers/bus/fslmc/fslmc_vfio.h | 1 -
>  drivers/bus/fslmc/version.map  | 4 +++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h
> index bc7c6f62d7..133606a9fd 100644
> --- a/drivers/bus/fslmc/fslmc_vfio.h
> +++ b/drivers/bus/fslmc/fslmc_vfio.h
> @@ -58,7 +58,6 @@ int fslmc_vfio_process_group(void);  char
> *fslmc_get_container(void);  int fslmc_get_container_group(int *gropuid);
> int rte_fslmc_vfio_dmamap(void); -__rte_experimental  int
> rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size);
> 
>  #endif /* _FSLMC_VFIO_H_ */
> diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
> index f44c1a7988..4e53ea048d 100644
> --- a/drivers/bus/fslmc/version.map
> +++ b/drivers/bus/fslmc/version.map
> @@ -1,7 +1,9 @@
> -EXPERIMENTAL {
> +DPDK_22 {
>  	global:
> 
>  	rte_fslmc_vfio_mem_dmamap;
> +
> +	local: *;
>  };
> 
>  INTERNAL {
> --
> 2.17.1
David Marchand Sept. 9, 2021, 7:50 a.m. UTC | #2 
On Fri, Sep 3, 2021 at 9:17 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
>
> This API was introduced in 19.08, therefore removing
> experimental tag to promote them to stable state.

The only user is an in-tree driver.
Do we need to export this symbol to applications?
Nipun Gupta Sept. 9, 2021, 7:54 a.m. UTC | #3 
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Thursday, September 9, 2021 1:21 PM
> To: Nipun Gupta <nipun.gupta@nxp.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>; dev <dev@dpdk.org>; Hemant
> Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena (OSS)
> <sachin.saxena@oss.nxp.com>; Ray Kinsella <mdr@ashroe.eu>
> Subject: Re: [PATCH 2/4] bus/fslmc: remove experimental tag from API
> 
> On Fri, Sep 3, 2021 at 9:17 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> >
> > This API was introduced in 19.08, therefore removing
> > experimental tag to promote them to stable state.
> 
> The only user is an in-tree driver.
> Do we need to export this symbol to applications?

Yes, we intend to export this PMD API to applications.

Regards,
Nipun

> 
> 
> --
> David Marchand
David Marchand Sept. 9, 2021, 8:01 a.m. UTC | #4 
On Thu, Sep 9, 2021 at 9:54 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> > > This API was introduced in 19.08, therefore removing
> > > experimental tag to promote them to stable state.
> >
> > The only user is an in-tree driver.
> > Do we need to export this symbol to applications?
>
> Yes, we intend to export this PMD API to applications.

Thanks for confirming.
Thomas Monjalon Sept. 24, 2021, 4:57 p.m. UTC | #5 
09/09/2021 10:01, David Marchand:
> On Thu, Sep 9, 2021 at 9:54 AM Nipun Gupta <nipun.gupta@nxp.com> wrote:
> > > > This API was introduced in 19.08, therefore removing
> > > > experimental tag to promote them to stable state.
> > >
> > > The only user is an in-tree driver.
> > > Do we need to export this symbol to applications?
> >
> > Yes, we intend to export this PMD API to applications.
> 
> Thanks for confirming.

Series applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/fslmc/fslmc_vfio.h b/drivers/bus/fslmc/fslmc_vfio.h
index bc7c6f62d7..133606a9fd 100644
--- a/drivers/bus/fslmc/fslmc_vfio.h
+++ b/drivers/bus/fslmc/fslmc_vfio.h
@@ -58,7 +58,6 @@  int fslmc_vfio_process_group(void);
 char *fslmc_get_container(void);
 int fslmc_get_container_group(int *gropuid);
 int rte_fslmc_vfio_dmamap(void);
-__rte_experimental
 int rte_fslmc_vfio_mem_dmamap(uint64_t vaddr, uint64_t iova, uint64_t size);
 
 #endif /* _FSLMC_VFIO_H_ */
diff --git a/drivers/bus/fslmc/version.map b/drivers/bus/fslmc/version.map
index f44c1a7988..4e53ea048d 100644
--- a/drivers/bus/fslmc/version.map
+++ b/drivers/bus/fslmc/version.map
@@ -1,7 +1,9 @@ 
-EXPERIMENTAL {
+DPDK_22 {
 	global:
 
 	rte_fslmc_vfio_mem_dmamap;
+
+	local: *;
 };
 
 INTERNAL {