app/test: fix pdcp short mac test

Message ID 20210916130242.126316-1-roy.fan.zhang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series app/test: fix pdcp short mac test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing fail Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Fan Zhang Sept. 16, 2021, 1:02 p.m. UTC
  Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I")
Cc: g.singh@nxp.com

This patch fixes the pdcp short mac-i test by removing them
from snow3g and kasumi test suite and move to pdcp test suite.
This is to prevent incorrect failure for crypto device not
support pdcp.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 app/test/test_cryptodev.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
  

Comments

Anoob Joseph Sept. 24, 2021, 10:38 a.m. UTC | #1
> Subject: [EXT] [dpdk-dev] app/test: fix pdcp short mac test
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I")
> Cc: g.singh@nxp.com
> 
> This patch fixes the pdcp short mac-i test by removing them from snow3g and
> kasumi test suite and move to pdcp test suite.
> This is to prevent incorrect failure for crypto device not support pdcp.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  app/test/test_cryptodev.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Acked-by: Anoob Joseph <anoobj@marvell.com>
  
Akhil Goyal Sept. 24, 2021, 5:22 p.m. UTC | #2
> > Fixes: c24489e479fd ("test/crypto: support PDCP short MAC-I")
> > Cc: g.singh@nxp.com
> >
> > This patch fixes the pdcp short mac-i test by removing them from snow3g
> and
> > kasumi test suite and move to pdcp test suite.
> > This is to prevent incorrect failure for crypto device not support pdcp.
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
 > Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 16d770a17f..d19482c20a 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -8886,6 +8886,7 @@  test_PDCP_PROTO_all(void)
 	status += test_PDCP_PROTO_SGL_oop_128B_32B();
 	status += test_PDCP_SDAP_PROTO_encap_all();
 	status += test_PDCP_SDAP_PROTO_decap_all();
+	status += test_PDCP_PROTO_short_mac();
 
 	if (status)
 		return TEST_FAILED;
@@ -14083,8 +14084,6 @@  static struct unit_test_suite cryptodev_snow3g_testsuite  = {
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_snow3g_encryption_test_case_5),
 
-		TEST_CASE_ST(ut_setup, ut_teardown,
-			test_PDCP_PROTO_short_mac),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_snow3g_encryption_test_case_1_oop),
 		TEST_CASE_ST(ut_setup, ut_teardown,
@@ -14324,9 +14323,6 @@  static struct unit_test_suite cryptodev_kasumi_testsuite  = {
 			test_kasumi_decryption_test_case_5),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_kasumi_decryption_test_case_1_oop),
-
-		TEST_CASE_ST(ut_setup, ut_teardown,
-			test_PDCP_PROTO_short_mac),
 		TEST_CASE_ST(ut_setup, ut_teardown,
 			test_kasumi_cipher_auth_test_case_1),